Fix(searches): Correct column pointer initialization in RowColumnWiseSorted2dArrayBinarySearch #6333
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6333 +/- ##
============================================
+ Coverage 74.17% 74.31% +0.14%
- Complexity 5362 5390 +28
============================================
Files 678 679 +1
Lines 18686 18820 +134
Branches 3625 3646 +21
============================================
+ Hits 13860 13987 +127
- Misses 4272 4275 +3
- Partials 554 558 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
codingmydna
force-pushed
the
fix/2d-array-search-bug
branch
from
41292a7 to
6ca8592
Compare
DenizAltunkapan
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.javaCloses #6332
This pull request fixes a bug in the
RowColumnWiseSorted2dArrayBinarySearch.javafile where the column pointer was incorrectly initialized.The Problem:
The column pointer (
colPointer) was being initialized withmatrix.length - 1. However,matrix.lengthreturns the number of rows, not columns. This causes the algorithm to start at an incorrect position and fail for any matrix that is not square.The Solution:
I have corrected the initialization to
int colPointer = matrix[0].length - 1;. This correctly uses the length of the first row to determine the number of columns, ensuring the pointer is set to the last column's index as intended by the algorithm's logic.