DRAFT: Discourse variables work #33383
Conversation
| @@ -38,7 +38,7 @@ | |||
| align-items: center; | |||
| justify-content: center; | |||
| border-radius: var(--d-border-radius); | |||
| border: 1px solid var(--primary-low); | |||
| border: 1px solid var(--content-border-color); | |||
There was a problem hiding this comment.
what's the difference between an input border and a content border?
There was a problem hiding this comment.
So content borders are things like table borders, and other border that separate content from other content in the same space.
The reason this isnt using input border, is because across the site input borders are more delinated. The menu here's border isn't the input, it is the drop down / pop up border
| @@ -125,12 +125,19 @@ | |||
| --gold: #{$gold}; | |||
| --silver: #{$silver}; | |||
| --bronze: #{$bronze}; | |||
| --read-color: var(--primary-medium); | |||
There was a problem hiding this comment.
probably fine for now, but might be better to keep color changes in a separate PR (makes it cleaner to revert if anything goes wrong)
| --metadata-color: var(--primary-medium); | ||
| --table-border-color: var(--primary-low); | ||
| --content-border-color: var(--primary-low); | ||
| --title-color: var(--primary); |
There was a problem hiding this comment.
what kind of title? topic lists? within topics? is it worth specifying or will we use this for lots of titles?
There was a problem hiding this comment.
I'd imagine titles will most likely be the same color across the site? Do you feel differently?
This draft PR is to track work related to introducing more css variables into discourse.