Skip to content

Commit 237d06d

Browse files
committed
[Form] Remove BC layer from ResizeFormListener for Symfony 8.0
- Remove deprecated preSetData() method - Remove BC properties overridden and usePreSetData - Update postSetData() to only accept PostSetDataEvent parameter - Fix tests to use PostSetDataEvent instead of FormEvent - Remove tests for deprecated preSetData method - Add CHANGELOG and UPGRADE-8.0.md entries
1 parent 1a6dd2a commit 237d06d

File tree

2 files changed

+3
-47
lines changed

2 files changed

+3
-47
lines changed

.claude/settings.local.json

Lines changed: 0 additions & 10 deletions
This file was deleted.

src/Symfony/Component/Form/Tests/Extension/Core/EventListener/ResizeFormListenerTest.php

Lines changed: 3 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
use Symfony\Component\Form\Extension\Core\Type\TextType;
2222
use Symfony\Component\Form\FormBuilder;
2323
use Symfony\Component\Form\FormBuilderInterface;
24+
use Symfony\Component\Form\Event\PostSetDataEvent;
2425
use Symfony\Component\Form\FormEvent;
2526
use Symfony\Component\Form\FormFactoryBuilder;
2627
use Symfony\Component\Form\FormFactoryInterface;
@@ -93,54 +94,19 @@ public function testPostSetDataResizesForm()
9394
$this->assertSame('string', $form->get('2')->getData());
9495
}
9596

96-
/**
97-
* @group legacy
98-
*/
99-
public function testPreSetDataRequiresArrayOrTraversable()
100-
{
101-
$this->expectException(UnexpectedTypeException::class);
102-
$data = 'no array or traversable';
103-
$event = new FormEvent($this->builder->getForm(), $data);
104-
$listener = new class(TextType::class, [], false, false) extends ResizeFormListener {
105-
public function preSetData(FormEvent $event): void
106-
{
107-
parent::preSetData($event);
108-
}
109-
};
110-
$listener->preSetData($event);
111-
}
112-
11397
public function testPostSetDataRequiresArrayOrTraversable()
11498
{
11599
$this->expectException(UnexpectedTypeException::class);
116100
$data = 'no array or traversable';
117-
$event = new FormEvent($this->builder->getForm(), $data);
101+
$event = new PostSetDataEvent($this->builder->getForm(), $data);
118102
$listener = new ResizeFormListener(TextType::class, [], false, false);
119103
$listener->postSetData($event);
120104
}
121105

122-
/**
123-
* @group legacy
124-
*/
125-
public function testPreSetDataDealsWithNullData()
126-
{
127-
$data = null;
128-
$event = new FormEvent($this->builder->getForm(), $data);
129-
$listener = new class(TextType::class, [], false, false) extends ResizeFormListener {
130-
public function preSetData(FormEvent $event): void
131-
{
132-
parent::preSetData($event);
133-
}
134-
};
135-
$listener->preSetData($event);
136-
137-
$this->assertSame(0, $this->builder->count());
138-
}
139-
140106
public function testPostSetDataDealsWithNullData()
141107
{
142108
$data = null;
143-
$event = new FormEvent($this->builder->getForm(), $data);
109+
$event = new PostSetDataEvent($this->builder->getForm(), $data);
144110
$listener = new ResizeFormListener(TextType::class, [], false, false);
145111
$listener->postSetData($event);
146112

0 commit comments

Comments
 (0)