fix: edit link will break the text styles #7863
Draft
+118
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis pull request fixes a bug where text styles (like bold, italic) were lost when creating or removing links. The implementation retrieves existing text attributes before modifying link-specific attributes, ensuring other styles are preserved. Link removal logic was also refactored into an File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @asjqkkkk - I've reviewed your changes - here's some feedback:
- Consider consolidating the
getAttributelogic to avoid duplication between the test and the extension. - The pattern of fetching existing attributes before formatting or replacing text is repeated; explore if this could be further refactored within the extension.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| if (start > startOffset) break; | ||
| final length = op.length; | ||
| if (start + length > startOffset) { | ||
| attributes = op.attributes ?? {}; |
There was a problem hiding this comment.
suggestion (bug_risk): Consider cloning the attributes to avoid unintended mutation.
Since _getAttribute returns op.attributes by reference, removing keys will mutate shared state. Clone the map first (e.g., with Map.from) before modifying.
Suggested change
| attributes = op.attributes ?? {}; | |
| attributes = op.attributes != null ? Map.from(op.attributes) : {}; |
asjqkkkk
force-pushed
the
fix/desktop/link
branch
from
ebe3ceb to
4651316
Compare
LucasXu0
reviewed
Apr 30, 2025
| @@ -8,32 +8,65 @@ extension LinkExtension on EditorState { | |||
| if (node == null) { | |||
| return; | |||
| } | |||
| final attributes = _getAttribute(node, selection); | |||
There was a problem hiding this comment.
I think we're not getting all the attributes from the selection. For example:
Before:
http://appflowy.io <- (add one more o here)
After:
http://appflowy.ioo The result should be ioo without extra formatting.
We have a slice attributes function that gets the attributes based on the index. appflowyEditorSliceAttributes
There was a problem hiding this comment.
yes, the logic about getting Attributes is not correct, I need to adjust it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Preview
PR Checklist
Summary by Sourcery
Fix an issue with editing links that could potentially break text styles in the document editor
Bug Fixes:
Enhancements:
Tests: