-
Notifications
You must be signed in to change notification settings - Fork 167
Comparing changes
Open a pull request
base repository: GoogleCloudPlatform/functions-framework-nodejs
base: v3.4.0
head repository: GoogleCloudPlatform/functions-framework-nodejs
compare: v3.4.1
- 6 commits
- 10 files changed
- 4 contributors
Commits on Jun 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 96ae8aa - Browse repository at this point
Copy the full SHA 96ae8aaView commit details
Commits on Jul 8, 2024
-
fix: if execution id support requested for node 12, fail open and dro…
…p execution id support instead of crashing out (#618)
Configuration menu - View commit details
-
Copy full SHA for 47003fd - Browse repository at this point
Copy the full SHA 47003fdView commit details
Commits on Jul 9, 2024
-
fix: parse structured logs, and handle ANSI escape codes in logs (#620)
`firebase-functions/logger` writes structured logs to stdout and stderr by default, and makes these pretty with ANSI color codes. When functions-framework intercepts these messages to assign execution IDs, it handles them incorrectly in two ways. First, when the log emitted on stdout or stderr is already a structured log, we override (ignore) the severity set by the logger. This commit avoids changing severity if it's already set. Second, when parsing the message and attempting to determine if it's already a json object/structured log, it doesn't handle ANSI escape codes (https://en.wikipedia.org/wiki/ANSI_escape_code) used to control color, so parsing these will fail. This means that severity handling falls back to just looking at whether the message came from stdout or stderr, so debug-level and warn-level logs aren't handled correctly. This commit strips all ANSI escape codes that control terminal color. This is a minor bummer because it's a whole lot less pretty, but color-coding and smarter color coding generally seems less important than correct log-level handling. Fixes #617.
Configuration menu - View commit details
-
Copy full SHA for 33a7266 - Browse repository at this point
Copy the full SHA 33a7266View commit details -
chore(deps-dev): bump braces from 3.0.2 to 3.0.3 (#614)
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jeremy Fehr <117788025+jrmfg@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 531fce2 - Browse repository at this point
Copy the full SHA 531fce2View commit details -
chore(deps-dev): bump braces from 3.0.2 to 3.0.3 in /experimental/gen…
…erate_cloud_events (#621) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for f419420 - Browse repository at this point
Copy the full SHA f419420View commit details -
chore(main): release 3.4.1 (#619)
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Jeremy Fehr <117788025+jrmfg@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for df37f6e - Browse repository at this point
Copy the full SHA df37f6eView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.4.0...v3.4.1