Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GoogleCloudPlatform/functions-framework-nodejs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.4.0
Choose a base ref
...
head repository: GoogleCloudPlatform/functions-framework-nodejs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.4.1
Choose a head ref
  • 6 commits
  • 10 files changed
  • 4 contributors

Commits on Jun 3, 2024

  1. Configuration menu
    Copy the full SHA
    96ae8aa View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. fix: if execution id support requested for node 12, fail open and dro…

    …p execution id support instead of crashing out (#618)
    jrmfg authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    47003fd View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. fix: parse structured logs, and handle ANSI escape codes in logs (#620)

    `firebase-functions/logger` writes structured logs to stdout and stderr by default, and makes these pretty with ANSI color codes.
    
    When functions-framework intercepts these messages to assign execution IDs, it handles them incorrectly in two ways.
    
    First, when the log emitted on stdout or stderr is already a structured log, we override (ignore) the severity set by the logger. This commit avoids changing severity if it's already set.
    
    Second, when parsing the message and attempting to determine if it's already a json object/structured log, it doesn't handle ANSI escape codes (https://en.wikipedia.org/wiki/ANSI_escape_code) used to control color, so parsing these will fail. This means that severity handling falls back to just looking at whether the message came from stdout or stderr, so debug-level and warn-level logs aren't handled correctly. This commit strips all ANSI escape codes that control terminal color. This is a minor bummer because it's a whole lot less pretty, but color-coding and smarter color coding generally seems less important than correct log-level handling.
    
    Fixes #617.
    jrmfg authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    33a7266 View commit details
    Browse the repository at this point in the history
  2. chore(deps-dev): bump braces from 3.0.2 to 3.0.3 (#614)

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Jeremy Fehr <117788025+jrmfg@users.noreply.github.com>
    dependabot[bot] and jrmfg authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    531fce2 View commit details
    Browse the repository at this point in the history
  3. chore(deps-dev): bump braces from 3.0.2 to 3.0.3 in /experimental/gen…

    …erate_cloud_events (#621)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f419420 View commit details
    Browse the repository at this point in the history
  4. chore(main): release 3.4.1 (#619)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    Co-authored-by: Jeremy Fehr <117788025+jrmfg@users.noreply.github.com>
    release-please[bot] and jrmfg authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    df37f6e View commit details
    Browse the repository at this point in the history
Loading