Skip to content

G-7730: Clarify scope #114

Closed
Closed
@PhilippSalvisberg

Description

@PhilippSalvisberg

Based on Connor McDonald's post More triggers are better I've checked the scope of the guideline. Here the results:

✅ ⠀Simple DML trigger (as in Connor's example)
✅ ⠀Compound DML trigger (same code as above in the before each row section)
⛔️ ⠀Instead of Trigger on views (not possible to assign :new values, no locks on the child table)

Maybe it's worth to mention that in the description of the rule.

BTW. Regarding the implementation of this validator check: The check is implemented only partially. I cannot find what's the primary key based on the trigger code (static code analysis without access to Oracle's data dictionary). Therefore I just assume that the primary key is assigned in the trigger. This might lead to false positives when the primary key is not assigned in the trigger code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions