Closed
Description
The examples in G-3145: Avoid using SELECT * directly from a table or view. violate rule G-4320: Always label your loops..
Here's the suggested solution for bad example:
begin
<<raise_salary>>
for r_employee in (
select *
from employees
)
loop
employee_api.calculate_raise_by_seniority(
id_in => r_employee.id
,salary_in => r_employee.salary
,hiredate_in => r_employee.hiredate
);
end loop raise_salary;
end;
/and here the suggested solution for the good example:
begin
<<raise_salary>>
for r_employee in (
select id,salary,hiredate
from employees
)
loop
employee_api.calculate_raise_by_seniority(
id_in => r_employee.id
,salary_in => r_employee.salary
,hiredate_in => r_employee.hiredate
);
end loop raise_salary;
end;
/