Skip to content

feat(signal-forms): Add key & index support in FieldContext #62347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: prototype/signal-forms
Choose a base branch
from
Draft

feat(signal-forms): Add key & index support in FieldContext #62347

wants to merge 2 commits into from
+206 −31

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jun 27, 2025 •
edited
Loading

TODO: try this and see if its worth the added type complexity:

Can a FieldPath know if it's generated from an array or object? We could encode the type of key() that way

@mmalerba mmalerba requested review from leonsenft, kirjs and alxhub June 27, 2025 19:27
@mmalerba mmalerba added area: forms target: feature This PR is targeted for a feature branch (outside of main and semver branches) labels Jun 27, 2025
@ngbot ngbot bot modified the milestone: Backlog Jun 27, 2025
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jun 27, 2025
@mmalerba mmalerba moved this to In Progress in Experimental Signal Forms Jun 27, 2025
@mmalerba mmalerba self-assigned this Jun 27, 2025
@mmalerba mmalerba marked this pull request as draft June 27, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonsenft leonsenft Awaiting requested review from leonsenft

@kirjs kirjs Awaiting requested review from kirjs

@alxhub alxhub Awaiting requested review from alxhub

Assignees

@mmalerba mmalerba

Labels
area: forms detected: feature PR contains a feature commit target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
Experimental Signal Forms
Status: In Progress
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
1 participant
@mmalerba