Skip to content

Commit 0150f51

Browse files
committed
Remove incorrect statement about closing on Attach
In some cases it might get closed but it is not a guarantee like the comment claims it is. While we could implement this behavior properly we already close the connection in the caller so it seems unnecessary.
1 parent 7409e7a commit 0150f51

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

agent/reconnectingpty/reconnectingpty.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ type ReconnectingPTY interface {
4444
// history, then blocks until EOF, an error, or the context's end. The
4545
// connection is expected to send JSON-encoded messages and accept raw output
4646
// from the ptty. If the context ends or the process dies the connection will
47-
// be detached and closed.
47+
// be detached.
4848
Attach(ctx context.Context, connID string, conn net.Conn, height, width uint16, logger slog.Logger) error
4949
// Wait waits for the reconnecting pty to close. The underlying process might
5050
// still be exiting.

0 commit comments

Comments
 (0)