chore: Refactor to allow matching on multiple constraints

mafredri · mafredri · commit 055d05afaa4b · 2022-08-24T15:43:28.000+03:00
diff --git a/coderd/database/errors.go b/coderd/database/errors.go
@@ -12,17 +12,25 @@ type UniqueConstraint string
 // UniqueConstraint enums.
 // TODO(mafredri): Generate these from the database schema.
 const (
-	UniqueConstraintAny                       UniqueConstraint = ""
-	UniqueConstraintWorkspacesOwnerIDLowerIdx UniqueConstraint = "workspaces_owner_id_lower_idx"
+	UniqueWorkspacesOwnerIDLowerIdx UniqueConstraint = "workspaces_owner_id_lower_idx"
 )
 
-func IsUniqueViolation(err error, uniqueConstraint UniqueConstraint) bool {
+// IsUniqueViolation checks if the error is due to a unique violation.
+// If specific cunique constraints are given as arguments, the error
+// must be caused by one of them. If no constraints are given, this
+// function returns true on any unique violation.
+func IsUniqueViolation(err error, uniqueConstraints ...UniqueConstraint) bool {
 	var pqErr *pq.Error
 	if errors.As(err, &pqErr) {
 		if pqErr.Code.Name() == "unique_violation" {
-			if pqErr.Constraint == string(uniqueConstraint) || uniqueConstraint == UniqueConstraintAny {
+			if len(uniqueConstraints) == 0 {
 				return true
 			}
+			for _, uc := range uniqueConstraints {
+				if pqErr.Constraint == string(uc) {
+					return true
+				}
+			}
 		}
 	}
 
diff --git a/coderd/workspaces.go b/coderd/workspaces.go
@@ -520,7 +520,7 @@ func (api *API) patchWorkspace(rw http.ResponseWriter, r *http.Request) {
 			return
 		}
 		// Check if the name was already in use.
-		if database.IsUniqueViolation(err, database.UniqueConstraintWorkspacesOwnerIDLowerIdx) {
+		if database.IsUniqueViolation(err, database.UniqueWorkspacesOwnerIDLowerIdx) {
 			httpapi.Write(rw, http.StatusConflict, codersdk.Response{
 				Message: fmt.Sprintf("Workspace %q already exists.", req.Name),
 				Validations: []codersdk.ValidationError{{

Original file line number	Diff line number	Diff line change
`@@ -520,7 +520,7 @@ func (api API) patchWorkspace(rw http.ResponseWriter, r http.Request) {`
`520`	`520`	`return`
`521`	`521`	`}`
`522`	`522`	`// Check if the name was already in use.`
`523`		`- if database.IsUniqueViolation(err, database.UniqueConstraintWorkspacesOwnerIDLowerIdx) {`
	`523`	`+ if database.IsUniqueViolation(err, database.UniqueWorkspacesOwnerIDLowerIdx) {`
`524`	`524`	`httpapi.Write(rw, http.StatusConflict, codersdk.Response{`
`525`	`525`	`Message: fmt.Sprintf("Workspace %q already exists.", req.Name),`
`526`	`526`	`Validations: []codersdk.ValidationError{{`