chore: Deprecate old cookie value (#4336)

Emyrk · web-flow · commit 0a95ba62b17f · 2022-10-03T13:04:22.000-04:00
Older clis will need to be updated.
Modern clis cannot communicate with &lt;8.15 coderd
diff --git a/coderd/httpmw/apikey.go b/coderd/httpmw/apikey.go
@@ -380,14 +380,6 @@ func apiTokenFromRequest(r *http.Request) string {
 		return cookie.Value
 	}
 
-	// TODO: @emyrk in October 2022, remove this oldCookie check.
-	//	This is just to support the old cli for 1 release. Then everyone
-	//	must update.
-	oldCookie, err := r.Cookie("session_token")
-	if err == nil && oldCookie.Value != "" {
-		return oldCookie.Value
-	}
-
 	urlValue := r.URL.Query().Get(codersdk.SessionTokenKey)
 	if urlValue != "" {
 		return urlValue
diff --git a/codersdk/client.go b/codersdk/client.go
@@ -83,13 +83,6 @@ func (c *Client) Request(ctx context.Context, method, path string, body interfac
 	}
 	req.Header.Set(SessionCustomHeader, c.SessionToken)
 
-	// Delete this custom cookie set in November 2022. This is just to remain
-	// backwards compatible with older versions of Coder.
-	req.AddCookie(&http.Cookie{
-		Name:  "session_token",
-		Value: c.SessionToken,
-	})
-
 	if body != nil {
 		req.Header.Set("Content-Type", "application/json")
 	}

Original file line number	Diff line number	Diff line change
`@@ -83,13 +83,6 @@ func (c *Client) Request(ctx context.Context, method, path string, body interfac`
`83`	`83`	`}`
`84`	`84`	`req.Header.Set(SessionCustomHeader, c.SessionToken)`
`85`	`85`
`86`		`- // Delete this custom cookie set in November 2022. This is just to remain`
`87`		`- // backwards compatible with older versions of Coder.`
`88`		`- req.AddCookie(&http.Cookie{`
`89`		`- Name: "session_token",`
`90`		`- Value: c.SessionToken,`
`91`		`- })`
`92`		`-`
`93`	`86`	`if body != nil {`
`94`	`87`	`req.Header.Set("Content-Type", "application/json")`
`95`	`88`	`}`