Skip to content

Commit 1d59a44

Browse files
committed
Fix RBAC
1 parent fb60891 commit 1d59a44

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

coderd/coderd_test.go

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -147,22 +147,16 @@ func TestAuthorizeAllEndpoints(t *testing.T) {
147147
"GET:/api/v2/workspaceagents/{workspaceagent}/turn": {NoAuthorize: true},
148148

149149
// These endpoints have more assertions. This is good, add more endpoints to assert if you can!
150-
"GET:/api/v2/organizations/{organization}": {AssertObject: rbac.ResourceOrganization.InOrg(admin.OrganizationID)},
151-
"GET:/api/v2/users/{user}/organizations": {StatusCode: http.StatusOK, AssertObject: rbac.ResourceOrganization},
152-
"GET:/api/v2/users/{user}/workspaces": {StatusCode: http.StatusOK, AssertObject: rbac.ResourceWorkspace},
153-
"GET:/api/v2/organizations/{organization}/workspaces/{user}": {StatusCode: http.StatusOK, AssertObject: rbac.ResourceWorkspace},
154-
"GET:/api/v2/organizations/{organization}/workspaces/{user}/{workspace}": {
155-
AssertObject: rbac.ResourceWorkspace.InOrg(organization.ID).WithID(workspace.ID.String()).WithOwner(workspace.OwnerID.String()),
156-
},
157-
"GET:/api/v2/workspaces/{workspace}/builds/{workspacebuildname}": {
150+
"GET:/api/v2/organizations/{organization}": {AssertObject: rbac.ResourceOrganization.InOrg(admin.OrganizationID)},
151+
"GET:/api/v2/users/{user}/organizations": {StatusCode: http.StatusOK, AssertObject: rbac.ResourceOrganization},
152+
"GET:/api/v2/users/{user}/workspace/{workspacename}": {
153+
AssertObject: rbac.ResourceWorkspace,
158154
AssertAction: rbac.ActionRead,
159-
AssertObject: workspaceRBACObj,
160155
},
161-
"GET:/api/v2/organizations/{organization}/workspaces/{user}/{workspacename}": {
156+
"GET:/api/v2/workspaces/{workspace}/builds/{workspacebuildname}": {
162157
AssertAction: rbac.ActionRead,
163158
AssertObject: workspaceRBACObj,
164159
},
165-
"GET:/api/v2/organizations/{organization}/workspaces": {StatusCode: http.StatusOK, AssertObject: rbac.ResourceWorkspace},
166160
"GET:/api/v2/workspacebuilds/{workspacebuild}": {
167161
AssertAction: rbac.ActionRead,
168162
AssertObject: workspaceRBACObj,

0 commit comments

Comments
 (0)