remove unused values

hugodutka · hugodutka · commit 1e30ddbb00e5 · 2025-01-30T17:58:53.000Z
diff --git a/coderd/telemetry/telemetry.go b/coderd/telemetry/telemetry.go
@@ -159,7 +159,7 @@ func (r *remoteReporter) reportSync(snapshot *Snapshot) {
 	}
 	if err := r.options.Database.UpsertTelemetryItem(r.ctx, database.UpsertTelemetryItemParams{
 		Key:   string(TelemetryItemKeyLastTelemetryUpdate),
-		Value: dbtime.Now().Format(time.RFC3339),
+		Value: "",
 	}); err != nil {
 		r.options.Logger.Debug(r.ctx, "upsert last telemetry update", slog.Error(err))
 	}
@@ -364,7 +364,7 @@ func (r *remoteReporter) ReportDisabledIfNeeded() error {
 
 	if err := db.UpsertTelemetryItem(r.ctx, database.UpsertTelemetryItemParams{
 		Key:   string(TelemetryItemKeyTelemetryDisabled),
-		Value: time.Now().Format(time.RFC3339),
+		Value: "",
 	}); err != nil {
 		return xerrors.Errorf("upsert telemetry disabled: %w", err)
 	}
diff --git a/coderd/telemetry/telemetry_test.go b/coderd/telemetry/telemetry_test.go
@@ -386,7 +386,7 @@ func TestReportDisabledIfNeeded(t *testing.T) {
 	// Report should be sent
 	_ = dbgen.TelemetryItem(t, db, database.TelemetryItem{
 		Key:   string(telemetry.TelemetryItemKeyLastTelemetryUpdate),
-		Value: time.Now().Format(time.RFC3339),
+		Value: "",
 	})
 	require.NoError(t, reporter.ReportDisabledIfNeeded())
 	select {
@@ -410,7 +410,7 @@ func TestReportDisabledIfNeeded(t *testing.T) {
 	time.Sleep(100 * time.Millisecond)
 	require.NoError(t, db.UpsertTelemetryItem(ctx, database.UpsertTelemetryItemParams{
 		Key:   string(telemetry.TelemetryItemKeyTelemetryDisabled),
-		Value: time.Now().Format(time.RFC3339),
+		Value: "",
 	}))
 	require.NoError(t, reporter.ReportDisabledIfNeeded())
 	select {

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ func (r remoteReporter) reportSync(snapshot Snapshot) {`
`159`	`159`	`}`
`160`	`160`	`if err := r.options.Database.UpsertTelemetryItem(r.ctx, database.UpsertTelemetryItemParams{`
`161`	`161`	`Key: string(TelemetryItemKeyLastTelemetryUpdate),`
`162`		`- Value: dbtime.Now().Format(time.RFC3339),`
	`162`	`+ Value: "",`
`163`	`163`	`}); err != nil {`
`164`	`164`	`r.options.Logger.Debug(r.ctx, "upsert last telemetry update", slog.Error(err))`
`165`	`165`	`}`
`@@ -364,7 +364,7 @@ func (r *remoteReporter) ReportDisabledIfNeeded() error {`
`364`	`364`
`365`	`365`	`if err := db.UpsertTelemetryItem(r.ctx, database.UpsertTelemetryItemParams{`
`366`	`366`	`Key: string(TelemetryItemKeyTelemetryDisabled),`
`367`		`- Value: time.Now().Format(time.RFC3339),`
	`367`	`+ Value: "",`
`368`	`368`	`}); err != nil {`
`369`	`369`	`return xerrors.Errorf("upsert telemetry disabled: %w", err)`
`370`	`370`	`}`