implement test using fake idp

Emyrk · Emyrk · commit 33541e680cab · 2024-01-19T12:33:00.000-06:00
diff --git a/coderd/coderdtest/oidctest/idp.go b/coderd/coderdtest/oidctest/idp.go
@@ -41,6 +41,7 @@ import (
 	"github.com/coder/coder/v2/coderd/promoauth"
 	"github.com/coder/coder/v2/coderd/util/syncmap"
 	"github.com/coder/coder/v2/codersdk"
+	"github.com/coder/coder/v2/testutil"
 )
 
 type token struct {
@@ -484,6 +485,30 @@ func (f *FakeIDP) ExternalLogin(t testing.TB, client *codersdk.Client, opts ...f
 	_ = res.Body.Close()
 }
 
+// DeviceLogin does the oauth2 device flow for external auth providers.
+func (f *FakeIDP) DeviceLogin(t testing.TB, client *codersdk.Client, externalAuthID string) {
+	// First we need to initiate the device flow. This will have Coder hit the
+	// fake IDP and get a device code.
+	device, err := client.ExternalAuthDeviceByID(context.Background(), externalAuthID)
+	require.NoError(t, err)
+
+	// Now the user needs to go to the fake IDP page and click "allow" and enter
+	// the device code input. For our purposes, we just send an http request to
+	// the verification url. No additional user input is needed.
+	ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitShort)
+	defer cancel()
+	_, err = client.Request(ctx, http.MethodPost, device.VerificationURI, nil)
+	require.NoError(t, err)
+
+	// Now we need to exchange the device code for an access token. We do this
+	// in this method because it is the user that does the polling for the device
+	// auth flow, not the backend.
+	err = client.ExternalAuthDeviceExchange(context.Background(), externalAuthID, codersdk.ExternalAuthDeviceExchange{
+		DeviceCode: device.DeviceCode,
+	})
+	require.NoError(t, err)
+}
+
 // CreateAuthCode emulates a user clicking "allow" on the IDP page. When doing
 // unit tests, it's easier to skip this step sometimes. It does make an actual
 // request to the IDP, so it should be equivalent to doing this "manually" with
diff --git a/coderd/externalauth_test.go b/coderd/externalauth_test.go
@@ -277,13 +277,8 @@ func TestExternalAuthDevice(t *testing.T) {
 			ExternalAuthConfigs: []*externalauth.Config{cfg},
 		})
 		coderdtest.CreateFirstUser(t, client)
-		device, err := client.ExternalAuthDeviceByID(context.Background(), externalID)
-		require.NoError(t, err)
-
-		ctx := testutil.Context(t, testutil.WaitShort)
-		resp, err := client.Request(ctx, http.MethodPost, device.VerificationURI, nil)
-		require.NoError(t, err)
-		fmt.Println(resp.StatusCode)
+		// Login!
+		fake.DeviceLogin(t, client, externalID)
 
 		extAuth, err := client.ExternalAuthByID(context.Background(), externalID)
 		require.NoError(t, err)
