refactor: remove displayError

BrunoQuaresma · BrunoQuaresma · commit 42a827e5419d · 2022-04-13T16:48:56.000Z
diff --git a/site/src/components/Snackbar/index.test.ts b/site/src/components/Snackbar/index.test.ts
@@ -1,4 +1,4 @@
-import { displayError, isNotificationTextPrefixed, MsgType, NotificationMsg } from "./index"
+import { displaySuccess, isNotificationTextPrefixed, MsgType, NotificationMsg } from "./index"
 
 describe("Snackbar", () => {
   describe("isNotificationTextPrefixed", () => {
@@ -15,7 +15,7 @@ describe("Snackbar", () => {
     })
   })
 
-  describe("displayError", () => {
+  describe("displaySuccess", () => {
     const originalWindowDispatchEvent = window.dispatchEvent
     let dispatchEventMock: jest.Mock
 
@@ -47,13 +47,13 @@ describe("Snackbar", () => {
     it("can be called with only a title", () => {
       // Given
       const expected: NotificationMsg = {
-        msgType: MsgType.Error,
+        msgType: MsgType.Success,
         msg: "Test",
         additionalMsgs: undefined,
       }
 
       // When
-      displayError("Test")
+      displaySuccess("Test")
 
       // Then
       expect(dispatchEventMock).toBeCalledTimes(1)
@@ -63,13 +63,13 @@ describe("Snackbar", () => {
     it("can be called with a title and additional message", () => {
       // Given
       const expected: NotificationMsg = {
-        msgType: MsgType.Error,
+        msgType: MsgType.Success,
         msg: "Test",
         additionalMsgs: ["additional message"],
       }
 
       // When
-      displayError("Test", "additional message")
+      displaySuccess("Test", "additional message")
 
       // Then
       expect(dispatchEventMock).toBeCalledTimes(1)
diff --git a/site/src/components/Snackbar/index.ts b/site/src/components/Snackbar/index.ts
@@ -66,7 +66,3 @@ export const displayMsg = (msg: string, additionalMsg?: string): void => {
 export const displaySuccess = (msg: string, additionalMsg?: string): void => {
   dispatchNotificationEvent(MsgType.Success, msg, additionalMsg ? [additionalMsg] : undefined)
 }
-
-export const displayError = (msg: string, additionalMsg?: string): void => {
-  dispatchNotificationEvent(MsgType.Error, msg, additionalMsg ? [additionalMsg] : undefined)
-}
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,3 @@ export const displayMsg = (msg: string, additionalMsg?: string): void => {`
`66`	`66`	`export const displaySuccess = (msg: string, additionalMsg?: string): void => {`
`67`	`67`	`dispatchNotificationEvent(MsgType.Success, msg, additionalMsg ? [additionalMsg] : undefined)`
`68`	`68`	`}`
`69`		`-`
`70`		`-export const displayError = (msg: string, additionalMsg?: string): void => {`
`71`		`- dispatchNotificationEvent(MsgType.Error, msg, additionalMsg ? [additionalMsg] : undefined)`
`72`		`-}`