fix tests

Emyrk · Emyrk · commit 453f22e2822c · 2024-08-13T13:51:49.000-05:00
diff --git a/coderd/httpmw/workspaceagentparam_test.go b/coderd/httpmw/workspaceagentparam_test.go
@@ -100,7 +100,7 @@ func TestWorkspaceAgentParam(t *testing.T) {
 	t.Run("NotAuthorized", func(t *testing.T) {
 		t.Parallel()
 		db := dbmem.New()
-		fakeAuthz := &coderdtest.FakeAuthorizer{AlwaysReturn: xerrors.Errorf("constant failure")}
+		fakeAuthz := (&coderdtest.FakeAuthorizer{}).AlwaysReturn(xerrors.Errorf("constant failure"))
 		dbFail := dbauthz.New(db, fakeAuthz, slog.Make(), coderdtest.AccessControlStorePointer())
 
 		rtr := chi.NewRouter()
diff --git a/coderd/rbac/authz_test.go b/coderd/rbac/authz_test.go
@@ -288,7 +288,7 @@ func benchmarkSetup(orgs []uuid.UUID, users []uuid.UUID, size int, opts ...func(
 // BenchmarkCacher benchmarks the performance of the cacher.
 func BenchmarkCacher(b *testing.B) {
 	ctx := context.Background()
-	authz := rbac.Cacher(&coderdtest.FakeAuthorizer{AlwaysReturn: nil})
+	authz := rbac.Cacher(&coderdtest.FakeAuthorizer{})
 
 	rats := []int{1, 10, 100}
 
@@ -322,7 +322,7 @@ func TestCache(t *testing.T) {
 
 		ctx := context.Background()
 		rec := &coderdtest.RecordingAuthorizer{
-			Wrapped: &coderdtest.FakeAuthorizer{AlwaysReturn: nil},
+			Wrapped: &coderdtest.FakeAuthorizer{},
 		}
 		subj, obj, action := coderdtest.RandomRBACSubject(), coderdtest.RandomRBACObject(), coderdtest.RandomRBACAction()
 
@@ -340,7 +340,7 @@ func TestCache(t *testing.T) {
 
 		ctx := context.Background()
 		rec := &coderdtest.RecordingAuthorizer{
-			Wrapped: &coderdtest.FakeAuthorizer{AlwaysReturn: nil},
+			Wrapped: &coderdtest.FakeAuthorizer{},
 		}
 		authz := rbac.Cacher(rec)
 		subj, obj, action := coderdtest.RandomRBACSubject(), coderdtest.RandomRBACObject(), coderdtest.RandomRBACAction()
@@ -400,7 +400,7 @@ func TestCache(t *testing.T) {
 
 		ctx := context.Background()
 		rec := &coderdtest.RecordingAuthorizer{
-			Wrapped: &coderdtest.FakeAuthorizer{AlwaysReturn: nil},
+			Wrapped: &coderdtest.FakeAuthorizer{},
 		}
 		authz := rbac.Cacher(rec)
 		subj1, obj1, action1 := coderdtest.RandomRBACSubject(), coderdtest.RandomRBACObject(), coderdtest.RandomRBACAction()
