debug

hugodutka · hugodutka · commit 51482c0be8f1 · 2024-11-15T11:38:31.000Z
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -409,6 +409,15 @@ jobs:
               print("Success")
               with open(github_output, 'a') as output_file:
                   print(f'{output_name}=success', file=output_file)
+      - if: failure()
+        run: echo "1" >> "pg_failed_${{ matrix.os }}"
+      - name: Upload failed artifact
+        uses: actions/upload-artifact@v4
+        if: failure()
+        with:
+          name: "pg_failed_${{ matrix.os }}"
+          path: "pg_failed_${{ matrix.os }}"
+
 
       # - name: Harden Runner
       #   uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
@@ -456,13 +465,13 @@ jobs:
       #       DB=ci gotestsum --format standard-quiet -- -v -short -count=1 ./...
       #     fi
 
-      - name: Upload test stats to Datadog
-        timeout-minutes: 1
-        continue-on-error: true
-        uses: ./.github/actions/upload-datadog
-        if: success() || failure()
-        with:
-          api-key: ${{ secrets.DATADOG_API_KEY }}
+      # - name: Upload test stats to Datadog
+      #   timeout-minutes: 1
+      #   continue-on-error: true
+      #   uses: ./.github/actions/upload-datadog
+      #   if: success() || failure()
+      #   with:
+      #     api-key: ${{ secrets.DATADOG_API_KEY }}
 
   # NOTE: this could instead be defined as a matrix strategy, but we want to
   # only block merging if tests on postgres 13 fail. Using a matrix strategy
@@ -836,13 +845,19 @@ jobs:
         uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
         with:
           egress-policy: audit
-
+      - name: Download PG Failed Artifacts
+        uses: actions/download-artifact@v4
+        with:
+          path: pg_failed
+          pattern: pg_failed_*
+          merge-multiple: true
       - name: Ensure required checks
         shell: python
         run: |
           import json
           import sys
           import os
+          from pathlib import Path
 
           print("Checking required checks")
           print(os.environ['NEEDS'])
@@ -857,14 +872,12 @@ jobs:
           failed = False
           for job_name in job_names:
               result = jobs[job_name]['result']
-              runner_os = jobs[job_name]['outputs'].get('runner_os')
-              
-              # Skip test-go-pg failures on windows
-              if (job_name == "test-go-pg" and
-                  "windows" in runner_os and
-                  result == "failure"):
-                  continue
               
+              # Skip test-go-pg failures on windowsx
+              if job_name == "test-go-pg" and result == "failure":
+                  failed_artifacts = list(Path("pg_failed").glob("pg_failed_*"))
+                  if len(failed_artifacts) == 1 and  "windows" in str(failed_artifacts[0].name):
+                      continue
               if result in ["failure", "cancelled"]:
                   failed = True
                   break
