Remove use of panics

Emyrk · Emyrk · commit 5ba346377e28 · 2023-01-31T10:06:14.000-06:00
diff --git a/coderd/database/databasefake/generator.go b/coderd/database/databasefake/generator.go
@@ -31,7 +31,9 @@ type Generator struct {
 
 func NewGenerator(t *testing.T, db database.Store) *Generator {
 	if _, ok := db.(FakeDatabase); !ok {
-		panic("Generator db must be a FakeDatabase")
+		// This does not work for postgres databases because of foreign key
+		// constraints
+		t.Fatalf("Generator db must be a FakeDatabase")
 	}
 	return &Generator{
 		names: make(map[string]uuid.UUID),
@@ -58,6 +60,7 @@ func (g *Generator) PrimaryOrg(ctx context.Context) database.Organization {
 }
 
 func populate[DBType any](ctx context.Context, g *Generator, name string, seed DBType) DBType {
+	g.testT.Helper()
 	if name == "" {
 		name = g.RandomName()
 	}
@@ -67,7 +70,7 @@ func populate[DBType any](ctx context.Context, g *Generator, name string, seed D
 	})
 	v, ok := out[name].(DBType)
 	if !ok {
-		panic("developer error, type mismatch")
+		g.testT.Fatalf("developer error, type mismatch in data generator")
 	}
 	return v
 }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,9 @@ type Generator struct {`
`31`	`31`
`32`	`32`	`func NewGenerator(t testing.T, db database.Store) Generator {`
`33`	`33`	`if _, ok := db.(FakeDatabase); !ok {`
`34`		`- panic("Generator db must be a FakeDatabase")`
	`34`	`+ // This does not work for postgres databases because of foreign key`
	`35`	`+ // constraints`
	`36`	`+ t.Fatalf("Generator db must be a FakeDatabase")`
`35`	`37`	`}`
`36`	`38`	`return &Generator{`
`37`	`39`	`names: make(map[string]uuid.UUID),`
`@@ -58,6 +60,7 @@ func (g *Generator) PrimaryOrg(ctx context.Context) database.Organization {`
`58`	`60`	`}`
`59`	`61`
`60`	`62`	`func populate[DBType any](ctx context.Context, g *Generator, name string, seed DBType) DBType {`
	`63`	`+ g.testT.Helper()`
`61`	`64`	`if name == "" {`
`62`	`65`	`name = g.RandomName()`
`63`	`66`	`}`
`@@ -67,7 +70,7 @@ func populate[DBType any](ctx context.Context, g *Generator, name string, seed D`
`67`	`70`	`})`
`68`	`71`	`v, ok := out[name].(DBType)`
`69`	`72`	`if !ok {`
`70`		`- panic("developer error, type mismatch")`
	`73`	`+ g.testT.Fatalf("developer error, type mismatch in data generator")`
`71`	`74`	`}`
`72`	`75`	`return v`
`73`	`76`	`}`