Extend wait period for test; drive-by fix for possibly flaky test

dannykopping · dannykopping · commit 5db00ce77c64 · 2024-07-18T16:28:18.000+02:00
Signed-off-by: Danny Kopping &lt;danny@coder.com&gt;
diff --git a/coderd/notifications/metrics_test.go b/coderd/notifications/metrics_test.go
@@ -263,9 +263,10 @@ func TestPendingUpdatesMetric(t *testing.T) {
 	interceptor.proceed.Broadcast()
 
 	// Validate that the store synced the expected number of updates.
-	require.Eventually(t, func() bool {
+	require.Eventuallyf(t, func() bool {
 		return syncer.sent.Load() == 1 && syncer.failed.Load() == 1
-	}, testutil.WaitShort, testutil.IntervalFast)
+	}, testutil.WaitLong, testutil.IntervalFast,
+		"sent: %d, failed: %d", syncer.sent.Load(), syncer.failed.Load())
 
 	// Wait for the updates to be synced and the metric to reflect that.
 	require.Eventually(t, func() bool {
