fix: appease linter

DanielleMaywood · DanielleMaywood · commit 60fc32cd095b · 2024-10-01T11:24:18.000Z
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -9077,7 +9077,7 @@ func (q *FakeQuerier) UpdateUserGithubComUserID(_ context.Context, arg database.
 	return sql.ErrNoRows
 }
 
-func (q *FakeQuerier) UpdateUserHashedOneTimePasscode(ctx context.Context, arg database.UpdateUserHashedOneTimePasscodeParams) error {
+func (q *FakeQuerier) UpdateUserHashedOneTimePasscode(_ context.Context, arg database.UpdateUserHashedOneTimePasscodeParams) error {
 	err := validateDatabaseType(arg)
 	if err != nil {
 		return err
diff --git a/coderd/userauth.go b/coderd/userauth.go
@@ -281,11 +281,15 @@ func (api *API) postRequestOneTimePasscode(rw http.ResponseWriter, r *http.Reque
 	aReq.New = newUser
 
 	// Send the one-time-passcode to the user.
-	api.notifyUserRequestedOneTimePasscode(ctx, user, passcode.String())
+	err = api.notifyUserRequestedOneTimePasscode(ctx, user, passcode.String())
+	if err != nil {
+		logger.Error(ctx, "unable to notify user about one time passcode request", slog.Error(err))
+	}
 }
 
-func (api *API) notifyUserRequestedOneTimePasscode(ctx context.Context, user database.User, passcode string) {
+func (api *API) notifyUserRequestedOneTimePasscode(ctx context.Context, user database.User, passcode string) error {
 	_, err := api.NotificationsEnqueuer.Enqueue(
+		//nolint:gocritic // We need to be able to send the user their one time passcode.
 		dbauthz.AsSystemRestricted(ctx),
 		user.ID,
 		notifications.TemplateUserRequestedOneTimePasscode,
@@ -294,8 +298,10 @@ func (api *API) notifyUserRequestedOneTimePasscode(ctx context.Context, user dat
 		user.ID,
 	)
 	if err != nil {
-		api.Logger.Warn(ctx, "unable to notify user about requested one-time-passcode", slog.F("affected_user", user.Username), slog.Error(err))
+		return xerrors.Errorf("enqueue notification: %w", err)
 	}
+
+	return nil
 }
 
 // Change a users password with a one-time-passcode.

Original file line number	Diff line number	Diff line change
`@@ -9077,7 +9077,7 @@ func (q *FakeQuerier) UpdateUserGithubComUserID(_ context.Context, arg database.`
`9077`	`9077`	`return sql.ErrNoRows`
`9078`	`9078`	`}`
`9079`	`9079`
`9080`		`-func (q *FakeQuerier) UpdateUserHashedOneTimePasscode(ctx context.Context, arg database.UpdateUserHashedOneTimePasscodeParams) error {`
	`9080`	`+func (q *FakeQuerier) UpdateUserHashedOneTimePasscode(_ context.Context, arg database.UpdateUserHashedOneTimePasscodeParams) error {`
`9081`	`9081`	`err := validateDatabaseType(arg)`
`9082`	`9082`	`if err != nil {`
`9083`	`9083`	`return err`