Skip to content

Commit 6580971

Browse files
blink-so[bot]kylecarbs
blink-so[bot]
and
kylecarbs
authored
feat: make readinessProbe and livenessProbe initialDelaySeconds configurable (#18756)
Makes `initialDelaySeconds` configurable for both `readinessProbe` and `livenessProbe` in the Helm chart. **Changes:** - Added `coder.readinessProbe.initialDelaySeconds` and `coder.livenessProbe.initialDelaySeconds` to `values.yaml` - Updated `_coder.tpl` template to use these configurable values - Defaults to 0 seconds to maintain existing behavior **Testing:** - Verified template rendering with default values (0) - Verified template rendering with custom values (30, 60) - Both probes correctly use the configured `initialDelaySeconds` --------- Co-authored-by: blink-so[bot] <211532188+blink-so[bot]@users.noreply.github.com> Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
1 parent a1c77e3 commit 6580971

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+106
-0
lines changed

‎helm/coder/templates/_coder.tpl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,11 @@ readinessProbe:
100100
path: /healthz
101101
port: "http"
102102
scheme: "HTTP"
103+
initialDelaySeconds: {{ .Values.coder.readinessProbe.initialDelaySeconds }}
103104
livenessProbe:
104105
httpGet:
105106
path: /healthz
106107
port: "http"
107108
scheme: "HTTP"
109+
initialDelaySeconds: {{ .Values.coder.livenessProbe.initialDelaySeconds }}
108110
{{- end }}

‎helm/coder/tests/testdata/auto_access_url_1.golden

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ spec:
171171
path: /healthz
172172
port: http
173173
scheme: HTTP
174+
initialDelaySeconds: 0
174175
name: coder
175176
ports:
176177
- containerPort: 8080
@@ -181,6 +182,7 @@ spec:
181182
path: /healthz
182183
port: http
183184
scheme: HTTP
185+
initialDelaySeconds: 0
184186
resources:
185187
limits:
186188
cpu: 2000m

‎helm/coder/tests/testdata/auto_access_url_1_coder.golden

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ spec:
171171
path: /healthz
172172
port: http
173173
scheme: HTTP
174+
initialDelaySeconds: 0
174175
name: coder
175176
ports:
176177
- containerPort: 8080
@@ -181,6 +182,7 @@ spec:
181182
path: /healthz
182183
port: http
183184
scheme: HTTP
185+
initialDelaySeconds: 0
184186
resources:
185187
limits:
186188
cpu: 2000m

‎helm/coder/tests/testdata/auto_access_url_2.golden

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ spec:
171171
path: /healthz
172172
port: http
173173
scheme: HTTP
174+
initialDelaySeconds: 0
174175
name: coder
175176
ports:
176177
- containerPort: 8080
@@ -181,6 +182,7 @@ spec:
181182
path: /healthz
182183
port: http
183184
scheme: HTTP
185+
initialDelaySeconds: 0
184186
resources:
185187
limits:
186188
cpu: 2000m

‎helm/coder/tests/testdata/auto_access_url_2_coder.golden

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ spec:
171171
path: /healthz
172172
port: http
173173
scheme: HTTP
174+
initialDelaySeconds: 0
174175
name: coder
175176
ports:
176177
- containerPort: 8080
@@ -181,6 +182,7 @@ spec:
181182
path: /healthz
182183
port: http
183184
scheme: HTTP
185+
initialDelaySeconds: 0
184186
resources:
185187
limits:
186188
cpu: 2000m

‎helm/coder/tests/testdata/auto_access_url_3.golden

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ spec:
169169
path: /healthz
170170
port: http
171171
scheme: HTTP
172+
initialDelaySeconds: 0
172173
name: coder
173174
ports:
174175
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
179180
path: /healthz
180181
port: http
181182
scheme: HTTP
183+
initialDelaySeconds: 0
182184
resources:
183185
limits:
184186
cpu: 2000m

‎helm/coder/tests/testdata/auto_access_url_3_coder.golden

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ spec:
169169
path: /healthz
170170
port: http
171171
scheme: HTTP
172+
initialDelaySeconds: 0
172173
name: coder
173174
ports:
174175
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
179180
path: /healthz
180181
port: http
181182
scheme: HTTP
183+
initialDelaySeconds: 0
182184
resources:
183185
limits:
184186
cpu: 2000m

‎helm/coder/tests/testdata/command.golden

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ spec:
169169
path: /healthz
170170
port: http
171171
scheme: HTTP
172+
initialDelaySeconds: 0
172173
name: coder
173174
ports:
174175
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
179180
path: /healthz
180181
port: http
181182
scheme: HTTP
183+
initialDelaySeconds: 0
182184
resources:
183185
limits:
184186
cpu: 2000m

‎helm/coder/tests/testdata/command_args.golden

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ spec:
170170
path: /healthz
171171
port: http
172172
scheme: HTTP
173+
initialDelaySeconds: 0
173174
name: coder
174175
ports:
175176
- containerPort: 8080
@@ -180,6 +181,7 @@ spec:
180181
path: /healthz
181182
port: http
182183
scheme: HTTP
184+
initialDelaySeconds: 0
183185
resources:
184186
limits:
185187
cpu: 2000m

‎helm/coder/tests/testdata/command_args_coder.golden

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ spec:
170170
path: /healthz
171171
port: http
172172
scheme: HTTP
173+
initialDelaySeconds: 0
173174
name: coder
174175
ports:
175176
- containerPort: 8080
@@ -180,6 +181,7 @@ spec:
180181
path: /healthz
181182
port: http
182183
scheme: HTTP
184+
initialDelaySeconds: 0
183185
resources:
184186
limits:
185187
cpu: 2000m

0 commit comments

Comments
 (0)