Skip to content

Commit 73d50c4

Browse files
committed
make gen impl
1 parent dea66c3 commit 73d50c4

File tree

2 files changed

+32
-3
lines changed

2 files changed

+32
-3
lines changed

coderd/database/dbauthz/dbauthz_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1995,6 +1995,14 @@ func (s *MethodTestSuite) TestWorkspace() {
19951995
// No asserts here because SQLFilter.
19961996
check.Args(ws.OwnerID, emptyPreparedAuthorized{}).Asserts()
19971997
}))
1998+
s.Run("GetWorkspaceBuildParametersByBuildIDs", s.Subtest(func(db database.Store, check *expects) {
1999+
// no asserts here because SQLFilter
2000+
check.Args([]uuid.UUID{}).Asserts()
2001+
}))
2002+
s.Run("GetAuthorizedWorkspaceBuildParametersByBuildIDs", s.Subtest(func(db database.Store, check *expects) {
2003+
// no asserts here because SQLFilter
2004+
check.Args([]uuid.UUID{}, emptyPreparedAuthorized{}).Asserts()
2005+
}))
19982006
s.Run("GetLatestWorkspaceBuildByWorkspaceID", s.Subtest(func(db database.Store, check *expects) {
19992007
u := dbgen.User(s.T(), db, database.User{})
20002008
o := dbgen.Organization(s.T(), db, database.Organization{})

coderd/database/dbmem/dbmem.go

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7926,8 +7926,9 @@ func (q *FakeQuerier) GetWorkspaceBuildParameters(_ context.Context, workspaceBu
79267926
return q.getWorkspaceBuildParametersNoLock(workspaceBuildID)
79277927
}
79287928

7929-
func (q *FakeQuerier) GetWorkspaceBuildParametersByBuildIDs(ctx context.Context, workspaceBuildIds []uuid.UUID) ([]database.WorkspaceBuildParameter, error) {
7930-
panic("not implemented")
7929+
func (q *FakeQuerier) GetWorkspaceBuildParametersByBuildIDs(ctx context.Context, workspaceBuildIDs []uuid.UUID) ([]database.WorkspaceBuildParameter, error) {
7930+
// No auth filter.
7931+
return q.GetAuthorizedWorkspaceBuildParametersByBuildIDs(ctx, workspaceBuildIDs, nil)
79317932
}
79327933

79337934
func (q *FakeQuerier) GetWorkspaceBuildStatsByTemplates(ctx context.Context, since time.Time) ([]database.GetWorkspaceBuildStatsByTemplatesRow, error) {
@@ -13807,7 +13808,27 @@ func (q *FakeQuerier) GetAuthorizedWorkspacesAndAgentsByOwnerID(ctx context.Cont
1380713808
}
1380813809

1380913810
func (q *FakeQuerier) GetAuthorizedWorkspaceBuildParametersByBuildIDs(ctx context.Context, workspaceBuildIDs []uuid.UUID, prepared rbac.PreparedAuthorized) ([]database.WorkspaceBuildParameter, error) {
13810-
panic("not implemented")
13811+
q.mutex.RLock()
13812+
defer q.mutex.RUnlock()
13813+
13814+
if prepared != nil {
13815+
// Call this to match the same function calls as the SQL implementation.
13816+
_, err := prepared.CompileToSQL(ctx, rbac.ConfigWithoutACL())
13817+
if err != nil {
13818+
return nil, err
13819+
}
13820+
}
13821+
13822+
filteredParameters := make([]database.WorkspaceBuildParameter, 0)
13823+
for _, buildID := range workspaceBuildIDs {
13824+
parameters, err := q.GetWorkspaceBuildParameters(ctx, buildID)
13825+
if err != nil {
13826+
return nil, err
13827+
}
13828+
filteredParameters = append(filteredParameters, parameters...)
13829+
}
13830+
13831+
return filteredParameters, nil
1381113832
}
1381213833

1381313834
func (q *FakeQuerier) GetAuthorizedUsers(ctx context.Context, arg database.GetUsersParams, prepared rbac.PreparedAuthorized) ([]database.GetUsersRow, error) {

0 commit comments

Comments
 (0)