Skip to content

Commit 7cbf190

Browse files
committed
Fix linting errors
1 parent 2c9fb64 commit 7cbf190

File tree

5 files changed

+15
-14
lines changed

5 files changed

+15
-14
lines changed

cli/create_test.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -700,8 +700,7 @@ func createTestParseResponseWithDefault(defaultValue string) []*proto.Parse_Resp
700700
}}
701701
}
702702

703-
type oauth2Config struct {
704-
}
703+
type oauth2Config struct{}
705704

706705
func (*oauth2Config) AuthCodeURL(state string, _ ...oauth2.AuthCodeOption) string {
707706
return "/?state=" + url.QueryEscape(state)
@@ -719,8 +718,7 @@ func (*oauth2Config) TokenSource(context.Context, *oauth2.Token) oauth2.TokenSou
719718
return &oauth2TokenSource{}
720719
}
721720

722-
type oauth2TokenSource struct {
723-
}
721+
type oauth2TokenSource struct{}
724722

725723
func (*oauth2TokenSource) Token() (*oauth2.Token, error) {
726724
return &oauth2.Token{

enterprise/audit/table.go

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -72,15 +72,16 @@ var AuditableResources = auditMap(map[any]map[string]Action{
7272
"allow_user_cancel_workspace_jobs": ActionTrack,
7373
},
7474
&database.TemplateVersion{}: {
75-
"id": ActionTrack,
76-
"template_id": ActionTrack,
77-
"organization_id": ActionIgnore, // Never changes.
78-
"created_at": ActionIgnore, // Never changes, but is implicit and not helpful in a diff.
79-
"updated_at": ActionIgnore, // Changes, but is implicit and not helpful in a diff.
80-
"name": ActionTrack,
81-
"readme": ActionTrack,
82-
"job_id": ActionIgnore, // Not helpful in a diff because jobs aren't tracked in audit logs.
83-
"created_by": ActionTrack,
75+
"id": ActionTrack,
76+
"template_id": ActionTrack,
77+
"organization_id": ActionIgnore, // Never changes.
78+
"created_at": ActionIgnore, // Never changes, but is implicit and not helpful in a diff.
79+
"updated_at": ActionIgnore, // Changes, but is implicit and not helpful in a diff.
80+
"name": ActionTrack,
81+
"readme": ActionTrack,
82+
"job_id": ActionIgnore, // Not helpful in a diff because jobs aren't tracked in audit logs.
83+
"created_by": ActionTrack,
84+
"git_auth_providers": ActionIgnore, // Not helpful because this can only change when new versions are added.
8485
},
8586
&database.User{}: {
8687
"id": ActionTrack,

site/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,6 @@
136136
"chrome 66",
137137
"firefox 63",
138138
"edge 79",
139-
"safari 15.5"
139+
"safari 15.4"
140140
]
141141
}

site/src/pages/GitAuthPage/GitAuthPage.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ const GitAuthPage: FC = () => {
1111
useEffect(() => {
1212
// This is used to notify the parent window that the Git auth token has been refreshed.
1313
// It's critical in the create workspace flow!
14+
// eslint-disable-next-line compat/compat -- It actually is supported... not sure why it's complaining.
1415
const bc = new BroadcastChannel(REFRESH_GITAUTH_BROADCAST_CHANNEL)
1516
// The message doesn't matter, any message refreshes the page!
1617
bc.postMessage("noop")

site/src/xServices/createWorkspace/createWorkspaceXService.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ export const createWorkspaceMachine =
167167
invoke: {
168168
id: "listenForRefreshGitAuth",
169169
src: () => (callback) => {
170+
// eslint-disable-next-line compat/compat -- It actually is supported... not sure why eslint is complaining.
170171
const bc = new BroadcastChannel(REFRESH_GITAUTH_BROADCAST_CHANNEL)
171172
bc.addEventListener("message", () => {
172173
callback("REFRESH_GITAUTH")

0 commit comments

Comments
 (0)