Skip to content

Commit 83a6722

Browse files
refactor: remove unnecessary JOIN
1 parent d040ddd commit 83a6722

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

coderd/database/queries.sql.go

Lines changed: 4 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

coderd/database/queries/prebuilds.sql

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,20 +19,18 @@ WHERE tvp.desired_instances IS NOT NULL -- Consider only presets that have a pre
1919
AND (t.id = sqlc.narg('template_id')::uuid OR sqlc.narg('template_id') IS NULL);
2020

2121
-- name: GetRunningPrebuilds :many
22-
SELECT p.id AS workspace_id,
23-
p.name AS workspace_name,
22+
SELECT p.id AS workspace_id,
23+
p.name AS workspace_name,
2424
p.template_id,
2525
b.template_version_id,
26-
tvp_curr.id AS current_preset_id,
26+
p.current_preset_id AS current_preset_id,
2727
CASE
2828
WHEN p.lifecycle_state = 'ready'::workspace_agent_lifecycle_state THEN TRUE
2929
ELSE FALSE END AS ready,
3030
p.created_at
3131
FROM workspace_prebuilds p
3232
INNER JOIN workspace_latest_builds b ON b.workspace_id = p.id
33-
INNER JOIN provisioner_jobs pj ON b.job_id = pj.id
34-
LEFT JOIN template_version_presets tvp_curr
35-
ON tvp_curr.id = p.current_preset_id -- See https://github.com/coder/internal/issues/398.
33+
INNER JOIN provisioner_jobs pj ON b.job_id = pj.id -- See https://github.com/coder/internal/issues/398.
3634
WHERE (b.transition = 'start'::workspace_transition
3735
AND pj.job_status = 'succeeded'::provisioner_job_status);
3836

0 commit comments

Comments
 (0)