fix: Return from update loop when job completes

kylecarbs · kylecarbs · commit 84dcda412dc1 · 2022-04-25T03:23:19.000Z
Update was running forever, which stopped jobs from timing
out unless a restart occurred. This also fixes complete properly
reporting an error.
diff --git a/provisionerd/provisionerd.go b/provisionerd/provisionerd.go
@@ -256,6 +256,8 @@ func (p *Server) runJob(ctx context.Context, job *proto.AcquiredJob) {
 				return
 			case <-ctx.Done():
 				return
+			case <-p.jobRunning:
+				return
 			case <-p.shutdown:
 				p.opts.Logger.Info(ctx, "attempting graceful cancelation")
 				shutdownCancel()
@@ -816,6 +818,7 @@ func (p *Server) completeJob(job *proto.CompletedJob) {
 		}
 		if err != nil {
 			p.opts.Logger.Warn(p.closeContext, "failed to complete job", slog.Error(err))
+			p.failActiveJobf(err.Error())
 			return
 		}
 		break
