again

f0ssel · f0ssel · commit 8b31d4959cc0 · 2024-02-01T21:33:52.000Z
diff --git a/coderd/templates.go b/coderd/templates.go
@@ -630,16 +630,15 @@ func (api *API) patchTemplateMeta(rw http.ResponseWriter, r *http.Request) {
 	if req.TimeTilDormantAutoDeleteMillis < 0 || (req.TimeTilDormantAutoDeleteMillis > 0 && req.TimeTilDormantAutoDeleteMillis < minTTL) {
 		validErrs = append(validErrs, codersdk.ValidationError{Field: "time_til_dormant_autodelete_ms", Detail: "Value must be at least one minute."})
 	}
+	maxPortShareLevel := template.MaxPortSharingLevel
 	if req.MaxPortSharingLevel != nil {
 		if *req.MaxPortSharingLevel < 0 || *req.MaxPortSharingLevel > 2 {
 			validErrs = append(validErrs, codersdk.ValidationError{Field: "max_port_sharing_level", Detail: "Value must be between 0 and 2."})
 		}
 		if !portSharer.CanRestrictSharing() {
 			validErrs = append(validErrs, codersdk.ValidationError{Field: "max_port_sharing_level", Detail: "Restricting port sharing level is an enterprise feature that is not enabled."})
 		}
-	}
-	maxPortShareLevel := template.MaxPortSharingLevel
-	if req.MaxPortSharingLevel != nil {
+
 		maxPortShareLevel = *req.MaxPortSharingLevel
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -630,16 +630,15 @@ func (api API) patchTemplateMeta(rw http.ResponseWriter, r http.Request) {`
`630`	`630`	`if req.TimeTilDormantAutoDeleteMillis < 0 \|\| (req.TimeTilDormantAutoDeleteMillis > 0 && req.TimeTilDormantAutoDeleteMillis < minTTL) {`
`631`	`631`	`validErrs = append(validErrs, codersdk.ValidationError{Field: "time_til_dormant_autodelete_ms", Detail: "Value must be at least one minute."})`
`632`	`632`	`}`
	`633`	`+ maxPortShareLevel := template.MaxPortSharingLevel`
`633`	`634`	`if req.MaxPortSharingLevel != nil {`
`634`	`635`	`if req.MaxPortSharingLevel < 0 \|\| req.MaxPortSharingLevel > 2 {`
`635`	`636`	`validErrs = append(validErrs, codersdk.ValidationError{Field: "max_port_sharing_level", Detail: "Value must be between 0 and 2."})`
`636`	`637`	`}`
`637`	`638`	`if !portSharer.CanRestrictSharing() {`
`638`	`639`	`validErrs = append(validErrs, codersdk.ValidationError{Field: "max_port_sharing_level", Detail: "Restricting port sharing level is an enterprise feature that is not enabled."})`
`639`	`640`	`}`
`640`		`- }`
`641`		`- maxPortShareLevel := template.MaxPortSharingLevel`
`642`		`- if req.MaxPortSharingLevel != nil {`
	`641`	`+`
`643`	`642`	`maxPortShareLevel = *req.MaxPortSharingLevel`
`644`	`643`	`}`
`645`	`644`