Fix revive lint

spikecurtis · spikecurtis · commit 8f68565b9693 · 2022-07-25T16:38:46.000-07:00
Signed-off-by: Spike Curtis &lt;spike@coder.com&gt;
diff --git a/pty/pty_other.go b/pty/pty_other.go
@@ -85,7 +85,7 @@ func (p *otherPtyWithProcess) Kill() error {
 	return p.cmd.Process.Kill()
 }
 
-func (p *otherPtyWithProcess) wait() {
+func (p *otherPtyWithProcess) waitInternal() {
 	// The GC can garbage collect the TTY FD before the command
 	// has finished running. See:
 	// https://github.com/creack/pty/issues/127#issuecomment-932764012
diff --git a/pty/pty_windows.go b/pty/pty_windows.go
@@ -120,7 +120,7 @@ func (p *ptyWindows) Close() error {
 	return nil
 }
 
-func (p *ptyWindowsWithProcess) wait() {
+func (p *ptyWindowsWithProcess) waitInternal() {
 	defer close(p.cmdDone)
 	state, err := p.proc.Wait()
 	if err != nil {
diff --git a/pty/start_other.go b/pty/start_other.go
@@ -44,6 +44,6 @@ func startPty(cmd *exec.Cmd) (WithProcess, error) {
 		cmd:     cmd,
 		cmdDone: make(chan any),
 	}
-	go oPty.wait()
+	go oPty.waitInternal()
 	return oPty, nil
 }
diff --git a/pty/start_windows.go b/pty/start_windows.go
@@ -88,7 +88,7 @@ func startPty(cmd *exec.Cmd) (WithProcess, error) {
 		cmdDone:    make(chan any),
 		proc:       process,
 	}
-	go pwp.wait()
+	go pwp.waitInternal()
 	return pwp, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ func (p *otherPtyWithProcess) Kill() error {`
`85`	`85`	`return p.cmd.Process.Kill()`
`86`	`86`	`}`
`87`	`87`
`88`		`-func (p *otherPtyWithProcess) wait() {`
	`88`	`+func (p *otherPtyWithProcess) waitInternal() {`
`89`	`89`	`// The GC can garbage collect the TTY FD before the command`
`90`	`90`	`// has finished running. See:`
`91`	`91`	`// https://github.com/creack/pty/issues/127#issuecomment-932764012`
Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ func (p *ptyWindows) Close() error {`
`120`	`120`	`return nil`
`121`	`121`	`}`
`122`	`122`
`123`		`-func (p *ptyWindowsWithProcess) wait() {`
	`123`	`+func (p *ptyWindowsWithProcess) waitInternal() {`
`124`	`124`	`defer close(p.cmdDone)`
`125`	`125`	`state, err := p.proc.Wait()`
`126`	`126`	`if err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,6 @@ func startPty(cmd *exec.Cmd) (WithProcess, error) {`
`44`	`44`	`cmd: cmd,`
`45`	`45`	`cmdDone: make(chan any),`
`46`	`46`	`}`
`47`		`- go oPty.wait()`
	`47`	`+ go oPty.waitInternal()`
`48`	`48`	`return oPty, nil`
`49`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ func startPty(cmd *exec.Cmd) (WithProcess, error) {`
`88`	`88`	`cmdDone: make(chan any),`
`89`	`89`	`proc: process,`
`90`	`90`	`}`
`91`		`- go pwp.wait()`
	`91`	`+ go pwp.waitInternal()`
`92`	`92`	`return pwp, nil`
`93`	`93`	`}`
`94`	`94`