Minor fixups

dannykopping · dannykopping · commit 91e2a2373fbc · 2024-07-09T17:09:35.000+02:00
Signed-off-by: Danny Kopping &lt;danny@coder.com&gt;
diff --git a/coderd/notifications/manager.go b/coderd/notifications/manager.go
@@ -222,7 +222,7 @@ func (m *Manager) syncUpdates(ctx context.Context) {
 	nSuccess := len(m.success)
 	nFailure := len(m.failure)
 
-	m.metrics.PendingUpdates.Set(float64(len(m.success) + len(m.failure)))
+	m.metrics.PendingUpdates.Set(float64(nSuccess + nFailure))
 
 	// Nothing to do.
 	if nSuccess+nFailure == 0 {
diff --git a/coderd/notifications/metrics_test.go b/coderd/notifications/metrics_test.go
@@ -153,7 +153,6 @@ func TestMetrics(t *testing.T) {
 		"coderd_notifications_inflight_dispatches": func(metric *dto.Metric, series string) bool {
 			// This is a gauge, so it can be difficult to get the timing right to catch it.
 			// See TestInflightDispatchesMetric for a more precise test.
-			// TODO: write it
 			return true
 		},
 		"coderd_notifications_pending_updates": func(metric *dto.Metric, series string) bool {
