fix: add timeout to listening ports request

coadler · coadler · commit 969eeaa23006 · 2024-01-30T18:10:58.000Z
This can potentially hang for 15m if the agent is unreachable.
diff --git a/coderd/workspaceagents.go b/coderd/workspaceagents.go
@@ -761,6 +761,8 @@ func (api *API) workspaceAgentLogs(rw http.ResponseWriter, r *http.Request) {
 func (api *API) workspaceAgentListeningPorts(rw http.ResponseWriter, r *http.Request) {
 	ctx := r.Context()
 	workspaceAgent := httpmw.WorkspaceAgentParam(r)
+	ctx, cancel := context.WithTimeout(ctx, 30*time.Second)
+	defer cancel()
 
 	apiAgent, err := db2sdk.WorkspaceAgent(
 		api.DERPMap(), *api.TailnetCoordinator.Load(), workspaceAgent, nil, nil, nil, api.AgentInactiveDisconnectTimeout,
