Add notes/todos

mafredri · mafredri · commit a57877a6ade4 · 2023-03-06T11:30:43.000Z
diff --git a/agent/agent.go b/agent/agent.go
@@ -1318,9 +1318,12 @@ func (a *agent) Close() error {
 
 	// Close services before running shutdown script.
 	// TODO(mafredri): Gracefully shutdown:
+	// - Cancel startup script, if running
 	// - Close active SSH server connections
 	// - Close processes (send HUP, wait, etc.)
 
+	// TODO(mafredri): Only run shutdown script if the agent is 'ready'?
+
 	lifecycleState := codersdk.WorkspaceAgentLifecycleOff
 	if metadata, ok := a.metadata.Load().(agentsdk.Metadata); ok {
 		scriptDone := make(chan error, 1)
@@ -1359,6 +1362,7 @@ func (a *agent) Close() error {
 	// Set final state and wait for it to be reported because context
 	// cancellation will stop the report loop.
 	a.setLifecycle(ctx, lifecycleState)
+	// TODO(mafredri): What if the agent token is revoked, build outdated, etc.?
 	for s := range a.lifecycleReported {
 		if s == lifecycleState {
 			break
