Skip to content

Commit a6a984f

Browse files
hugodutkahugodutka
committed
remove GetHTMLFirstServedAt and SetHTMLFirstServedAt
1 parent 5118aeb commit a6a984f

File tree

9 files changed

+0
-127
lines changed

9 files changed

+0
-127
lines changed

‎coderd/database/dbauthz/dbauthz.go

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2096,13 +2096,6 @@ func (q *querier) GetTailnetTunnelPeerIDs(ctx context.Context, srcID uuid.UUID)
20962096
return q.db.GetTailnetTunnelPeerIDs(ctx, srcID)
20972097
}
20982098

2099-
func (q *querier) GetTelemetryHTMLFirstServedAt(ctx context.Context) (string, error) {
2100-
if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceSystem); err != nil {
2101-
return "", err
2102-
}
2103-
return q.db.GetTelemetryHTMLFirstServedAt(ctx)
2104-
}
2105-
21062099
func (q *querier) GetTelemetryItem(ctx context.Context, key string) (database.TelemetryItem, error) {
21072100
if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceSystem); err != nil {
21082101
return database.TelemetryItem{}, err
@@ -3456,13 +3449,6 @@ func (q *querier) RevokeDBCryptKey(ctx context.Context, activeKeyDigest string)
34563449
return q.db.RevokeDBCryptKey(ctx, activeKeyDigest)
34573450
}
34583451

3459-
func (q *querier) SetTelemetryHTMLFirstServedAt(ctx context.Context, value string) error {
3460-
if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceSystem); err != nil {
3461-
return err
3462-
}
3463-
return q.db.SetTelemetryHTMLFirstServedAt(ctx, value)
3464-
}
3465-
34663452
func (q *querier) TryAcquireLock(ctx context.Context, id int64) (bool, error) {
34673453
return q.db.TryAcquireLock(ctx, id)
34683454
}

‎coderd/database/dbauthz/dbauthz_test.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4224,12 +4224,6 @@ func (s *MethodTestSuite) TestSystemFunctions() {
42244224
s.Run("GetWorkspaceModulesCreatedAfter", s.Subtest(func(db database.Store, check *expects) {
42254225
check.Args(dbtime.Now()).Asserts(rbac.ResourceSystem, policy.ActionRead)
42264226
}))
4227-
s.Run("GetTelemetryHTMLFirstServedAt", s.Subtest(func(db database.Store, check *expects) {
4228-
check.Args().Asserts(rbac.ResourceSystem, policy.ActionRead).Errors(sql.ErrNoRows)
4229-
}))
4230-
s.Run("SetTelemetryHTMLFirstServedAt", s.Subtest(func(db database.Store, check *expects) {
4231-
check.Args(time.Now().Format(time.RFC3339)).Asserts(rbac.ResourceSystem, policy.ActionUpdate)
4232-
}))
42334227
s.Run("GetTelemetryItem", s.Subtest(func(db database.Store, check *expects) {
42344228
check.Args("test").Asserts(rbac.ResourceSystem, policy.ActionRead).Errors(sql.ErrNoRows)
42354229
}))

‎coderd/database/dbmem/dbmem.go

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -4333,16 +4333,6 @@ func (*FakeQuerier) GetTailnetTunnelPeerIDs(context.Context, uuid.UUID) ([]datab
43334333
return nil, ErrUnimplemented
43344334
}
43354335

4336-
func (q *FakeQuerier) GetTelemetryHTMLFirstServedAt(ctx context.Context) (string, error) {
4337-
q.mutex.RLock()
4338-
defer q.mutex.RUnlock()
4339-
if q.htmlFirstServedAt == "" {
4340-
return "", sql.ErrNoRows
4341-
}
4342-
4343-
return q.htmlFirstServedAt, nil
4344-
}
4345-
43464336
func (q *FakeQuerier) GetTelemetryItem(_ context.Context, key string) (database.TelemetryItem, error) {
43474337
q.mutex.RLock()
43484338
defer q.mutex.RUnlock()
@@ -9177,16 +9167,6 @@ func (q *FakeQuerier) RevokeDBCryptKey(_ context.Context, activeKeyDigest string
91779167
return sql.ErrNoRows
91789168
}
91799169

9180-
func (q *FakeQuerier) SetTelemetryHTMLFirstServedAt(ctx context.Context, value string) error {
9181-
q.mutex.Lock()
9182-
defer q.mutex.Unlock()
9183-
if q.htmlFirstServedAt != "" {
9184-
return nil
9185-
}
9186-
q.htmlFirstServedAt = value
9187-
return nil
9188-
}
9189-
91909170
func (*FakeQuerier) TryAcquireLock(_ context.Context, _ int64) (bool, error) {
91919171
return false, xerrors.New("TryAcquireLock must only be called within a transaction")
91929172
}

‎coderd/database/dbmetrics/querymetrics.go

Lines changed: 0 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎coderd/database/dbmock/dbmock.go

Lines changed: 0 additions & 29 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎coderd/database/querier.go

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎coderd/database/queries.sql.go

Lines changed: 0 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎coderd/database/queries/siteconfig.sql

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,3 @@ ON CONFLICT (key) DO UPDATE SET value = $2 WHERE site_configs.key = $1;
106106
-- name: DeleteRuntimeConfig :exec
107107
DELETE FROM site_configs
108108
WHERE site_configs.key = $1;
109-
110-
-- name: SetTelemetryHTMLFirstServedAt :exec
111-
INSERT INTO site_configs (key, value)
112-
VALUES ('telemetry_html_first_served_at', $1)
113-
ON CONFLICT (key) DO NOTHING;
114-
115-
-- name: GetTelemetryHTMLFirstServedAt :one
116-
SELECT value FROM site_configs WHERE key = 'telemetry_html_first_served_at';

‎coderd/telemetry/telemetry.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -330,18 +330,6 @@ func checkIDPOrgSync(ctx context.Context, db database.Store, values *codersdk.De
330330
return syncConfig.Field != "", nil
331331
}
332332

333-
func getHTMLFirstServedAt(ctx context.Context, db database.Store) (*time.Time, error) {
334-
htmlFirstServedAtStr, err := db.GetTelemetryHTMLFirstServedAt(ctx)
335-
if err != nil {
336-
return nil, xerrors.Errorf("get telemetry html first served at: %w", err)
337-
}
338-
t, err := time.Parse(time.RFC3339, htmlFirstServedAtStr)
339-
if err != nil {
340-
return nil, xerrors.Errorf("parse telemetry html first served at: %w", err)
341-
}
342-
return &t, nil
343-
}
344-
345333
// createSnapshot collects a full snapshot from the database.
346334
func (r *remoteReporter) createSnapshot() (*Snapshot, error) {
347335
var (

0 commit comments

Comments
 (0)