fix(password): display only if password is set

defelmnq · defelmnq · commit a6ee1cc8438f · 2024-10-24T04:06:58.000+02:00
diff --git a/site/src/pages/CreateUserPage/CreateUserForm.tsx b/site/src/pages/CreateUserPage/CreateUserForm.tsx
@@ -205,7 +205,7 @@ export const CreateUserForm: FC<
 							helperText:
 								(form.values.login_type !== "password" &&
 									"No password required for this login type") ||
-								(!passwordIsValid && "password is not strong."),
+								(form.values.password !== "" && !passwordIsValid && "password is not strong."),
 						})}
 						autoComplete="current-password"
 						fullWidth
diff --git a/site/src/pages/SetupPage/SetupPageView.tsx b/site/src/pages/SetupPage/SetupPageView.tsx
@@ -183,7 +183,7 @@ export const SetupPageView: FC<SetupPageViewProps> = ({
 						id="password"
 						label={Language.passwordLabel}
 						type="password"
-						helperText={!passwordIsValid ? "Password is not strong." : ""} // Provide feedback
+						helperText={form.values.password !== "" && !passwordIsValid ? "Password is not strong." : ""}
 					/>
 					<label
 						htmlFor="trial"
diff --git a/site/src/pages/UserSettingsPage/SecurityPage/SecurityForm.tsx b/site/src/pages/UserSettingsPage/SecurityPage/SecurityForm.tsx
@@ -96,7 +96,7 @@ export const SecurityForm: FC<SecurityFormProps> = ({
 						autoComplete="password"
 						fullWidth
 						label={Language.newPasswordLabel}
-						helperText={!passwordIsValid ? "Password is not strong." : ""} // Provide feedback
+						helperText={form.values.password !== "" && !passwordIsValid ? "Password is not strong." : ""}
 						type="password"
 					/>
 					<TextField
