Fix linting

kylecarbs · kylecarbs · commit aa577c2afade · 2024-07-30T15:57:33.000Z
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -8094,7 +8094,7 @@ func (q *FakeQuerier) UpdateUserDeletedByID(_ context.Context, id uuid.UUID) err
 	return sql.ErrNoRows
 }
 
-func (q *FakeQuerier) UpdateUserGithubComUserID(ctx context.Context, arg database.UpdateUserGithubComUserIDParams) error {
+func (q *FakeQuerier) UpdateUserGithubComUserID(_ context.Context, arg database.UpdateUserGithubComUserIDParams) error {
 	err := validateDatabaseType(arg)
 	if err != nil {
 		return err
diff --git a/coderd/externalauth/externalauth.go b/coderd/externalauth/externalauth.go
@@ -968,9 +968,9 @@ func (r roundTripper) RoundTrip(req *http.Request) (*http.Response, error) {
 // IsGithubDotComURL returns true if the given URL is a github.com URL.
 func IsGithubDotComURL(str string) bool {
 	str = strings.ToLower(str)
-	url, err := url.Parse(str)
+	ghUrl, err := url.Parse(str)
 	if err != nil {
 		return false
 	}
-	return url.Host == "github.com"
+	return ghUrl.Host == "github.com"
 }
diff --git a/site/src/pages/ExternalAuthPage/ExternalAuthPageView.stories.tsx b/site/src/pages/ExternalAuthPage/ExternalAuthPageView.stories.tsx
@@ -22,6 +22,7 @@ WebAuthenticated.args = {
     app_installable: false,
     display_name: "BitBucket",
     user: {
+      id: 0,
       avatar_url: "https://avatars.githubusercontent.com/u/7122116?v=4",
       login: "kylecarbs",
       name: "Kyle Carberry",
@@ -104,6 +105,7 @@ DeviceAuthenticatedNotInstalled.args = {
     app_install_url: "https://example.com",
     app_installable: true,
     user: {
+      id: 0,
       avatar_url: "https://avatars.githubusercontent.com/u/7122116?v=4",
       login: "kylecarbs",
       name: "Kyle Carberry",
@@ -123,6 +125,7 @@ DeviceAuthenticatedInstalled.args = {
         configure_url: "https://example.com",
         id: 1,
         account: {
+          id: 0,
           avatar_url: "https://github.com/coder.png",
           login: "coder",
           name: "Coder",
@@ -133,6 +136,7 @@ DeviceAuthenticatedInstalled.args = {
     app_install_url: "https://example.com",
     app_installable: true,
     user: {
+      id: 0,
       avatar_url: "https://avatars.githubusercontent.com/u/7122116?v=4",
       login: "kylecarbs",
       name: "Kyle Carberry",

Original file line number	Diff line number	Diff line change
`@@ -8094,7 +8094,7 @@ func (q *FakeQuerier) UpdateUserDeletedByID(_ context.Context, id uuid.UUID) err`
`8094`	`8094`	`return sql.ErrNoRows`
`8095`	`8095`	`}`
`8096`	`8096`
`8097`		`-func (q *FakeQuerier) UpdateUserGithubComUserID(ctx context.Context, arg database.UpdateUserGithubComUserIDParams) error {`
	`8097`	`+func (q *FakeQuerier) UpdateUserGithubComUserID(_ context.Context, arg database.UpdateUserGithubComUserIDParams) error {`
`8098`	`8098`	`err := validateDatabaseType(arg)`
`8099`	`8099`	`if err != nil {`
`8100`	`8100`	`return err`
Original file line number	Diff line number	Diff line change
`@@ -968,9 +968,9 @@ func (r roundTripper) RoundTrip(req http.Request) (http.Response, error) {`
`968`	`968`	`// IsGithubDotComURL returns true if the given URL is a github.com URL.`
`969`	`969`	`func IsGithubDotComURL(str string) bool {`
`970`	`970`	`str = strings.ToLower(str)`
`971`		`- url, err := url.Parse(str)`
	`971`	`+ ghUrl, err := url.Parse(str)`
`972`	`972`	`if err != nil {`
`973`	`973`	`return false`
`974`	`974`	`}`
`975`		`- return url.Host == "github.com"`
	`975`	`+ return ghUrl.Host == "github.com"`
`976`	`976`	`}`