bad printlns

sreya · sreya · commit ab86fee5a306 · 2023-11-09T08:19:37.000Z
diff --git a/coderd/workspaces.go b/coderd/workspaces.go
@@ -1083,7 +1083,6 @@ func (api *API) resolveAutostart(rw http.ResponseWriter, r *http.Request) {
 	templateAccessControl := (*(api.AccessControlStore.Load())).GetTemplateAccessControl(template)
 	useActiveVersion := templateAccessControl.RequireActiveVersion || workspace.AutomaticUpdates == database.AutomaticUpdatesAlways
 	if !useActiveVersion {
-		fmt.Println("NOACTIVE????")
 		httpapi.Write(ctx, rw, http.StatusOK, codersdk.ResolveAutostartResponse{})
 		return
 	}
@@ -1098,7 +1097,6 @@ func (api *API) resolveAutostart(rw http.ResponseWriter, r *http.Request) {
 	}
 
 	if build.TemplateVersionID == template.ActiveVersionID {
-		fmt.Println("SHITTTT")
 		httpapi.Write(ctx, rw, http.StatusOK, codersdk.ResolveAutostartResponse{})
 		return
 	}
@@ -1138,7 +1136,6 @@ func (api *API) resolveAutostart(rw http.ResponseWriter, r *http.Request) {
 		})
 		return
 	}
-	fmt.Println("build params: ", len(dbBuildParams))
 
 	resolver := codersdk.ParameterResolver{
 		Rich: db2sdk.WorkspaceBuildParameters(dbBuildParams),
diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go
@@ -362,9 +362,8 @@ func TestResolveAutostart(t *testing.T) {
 		OrganizationID: template.OrganizationID,
 		CreatedBy:      owner.UserID,
 	}, database.ProvisionerJob{}, []database.TemplateVersionParameter{{
-		Name:         "param",
-		DefaultValue: "",
-		Required:     true,
+		Name:     "param",
+		Required: true,
 	}})
 
 	ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
diff --git a/enterprise/coderd/workspaces_test.go b/enterprise/coderd/workspaces_test.go
@@ -1105,9 +1105,8 @@ func TestResolveAutostart(t *testing.T) {
 		OrganizationID: template.OrganizationID,
 		CreatedBy:      owner.UserID,
 	}, database.ProvisionerJob{}, []database.TemplateVersionParameter{{
-		Name:         "param",
-		DefaultValue: "",
-		Required:     true,
+		Name:     "param",
+		Required: true,
 	}})
 
 	client, member := coderdtest.CreateAnotherUser(t, ownerClient, owner.OrganizationID)

Original file line number	Diff line number	Diff line change
`@@ -1083,7 +1083,6 @@ func (api API) resolveAutostart(rw http.ResponseWriter, r http.Request) {`
`1083`	`1083`	`templateAccessControl := (*(api.AccessControlStore.Load())).GetTemplateAccessControl(template)`
`1084`	`1084`	`useActiveVersion := templateAccessControl.RequireActiveVersion \|\| workspace.AutomaticUpdates == database.AutomaticUpdatesAlways`
`1085`	`1085`	`if !useActiveVersion {`
`1086`		`- fmt.Println("NOACTIVE????")`
`1087`	`1086`	`httpapi.Write(ctx, rw, http.StatusOK, codersdk.ResolveAutostartResponse{})`
`1088`	`1087`	`return`
`1089`	`1088`	`}`
`@@ -1098,7 +1097,6 @@ func (api API) resolveAutostart(rw http.ResponseWriter, r http.Request) {`
`1098`	`1097`	`}`
`1099`	`1098`
`1100`	`1099`	`if build.TemplateVersionID == template.ActiveVersionID {`
`1101`		`- fmt.Println("SHITTTT")`
`1102`	`1100`	`httpapi.Write(ctx, rw, http.StatusOK, codersdk.ResolveAutostartResponse{})`
`1103`	`1101`	`return`
`1104`	`1102`	`}`
`@@ -1138,7 +1136,6 @@ func (api API) resolveAutostart(rw http.ResponseWriter, r http.Request) {`
`1138`	`1136`	`})`
`1139`	`1137`	`return`
`1140`	`1138`	`}`
`1141`		`- fmt.Println("build params: ", len(dbBuildParams))`
`1142`	`1139`
`1143`	`1140`	`resolver := codersdk.ParameterResolver{`
`1144`	`1141`	`Rich: db2sdk.WorkspaceBuildParameters(dbBuildParams),`