Skip to content

Commit ac6a674

Browse files
committed
make gen impl
1 parent 636e2c1 commit ac6a674

File tree

2 files changed

+32
-3
lines changed

2 files changed

+32
-3
lines changed

coderd/database/dbauthz/dbauthz_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1994,6 +1994,14 @@ func (s *MethodTestSuite) TestWorkspace() {
19941994
// No asserts here because SQLFilter.
19951995
check.Args(ws.OwnerID, emptyPreparedAuthorized{}).Asserts()
19961996
}))
1997+
s.Run("GetWorkspaceBuildParametersByBuildIDs", s.Subtest(func(db database.Store, check *expects) {
1998+
// no asserts here because SQLFilter
1999+
check.Args([]uuid.UUID{}).Asserts()
2000+
}))
2001+
s.Run("GetAuthorizedWorkspaceBuildParametersByBuildIDs", s.Subtest(func(db database.Store, check *expects) {
2002+
// no asserts here because SQLFilter
2003+
check.Args([]uuid.UUID{}, emptyPreparedAuthorized{}).Asserts()
2004+
}))
19972005
s.Run("GetLatestWorkspaceBuildByWorkspaceID", s.Subtest(func(db database.Store, check *expects) {
19982006
u := dbgen.User(s.T(), db, database.User{})
19992007
o := dbgen.Organization(s.T(), db, database.Organization{})

coderd/database/dbmem/dbmem.go

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7960,8 +7960,9 @@ func (q *FakeQuerier) GetWorkspaceBuildParameters(_ context.Context, workspaceBu
79607960
return q.getWorkspaceBuildParametersNoLock(workspaceBuildID)
79617961
}
79627962

7963-
func (q *FakeQuerier) GetWorkspaceBuildParametersByBuildIDs(ctx context.Context, workspaceBuildIds []uuid.UUID) ([]database.WorkspaceBuildParameter, error) {
7964-
panic("not implemented")
7963+
func (q *FakeQuerier) GetWorkspaceBuildParametersByBuildIDs(ctx context.Context, workspaceBuildIDs []uuid.UUID) ([]database.WorkspaceBuildParameter, error) {
7964+
// No auth filter.
7965+
return q.GetAuthorizedWorkspaceBuildParametersByBuildIDs(ctx, workspaceBuildIDs, nil)
79657966
}
79667967

79677968
func (q *FakeQuerier) GetWorkspaceBuildStatsByTemplates(ctx context.Context, since time.Time) ([]database.GetWorkspaceBuildStatsByTemplatesRow, error) {
@@ -13848,7 +13849,27 @@ func (q *FakeQuerier) GetAuthorizedWorkspacesAndAgentsByOwnerID(ctx context.Cont
1384813849
}
1384913850

1385013851
func (q *FakeQuerier) GetAuthorizedWorkspaceBuildParametersByBuildIDs(ctx context.Context, workspaceBuildIDs []uuid.UUID, prepared rbac.PreparedAuthorized) ([]database.WorkspaceBuildParameter, error) {
13851-
panic("not implemented")
13852+
q.mutex.RLock()
13853+
defer q.mutex.RUnlock()
13854+
13855+
if prepared != nil {
13856+
// Call this to match the same function calls as the SQL implementation.
13857+
_, err := prepared.CompileToSQL(ctx, rbac.ConfigWithoutACL())
13858+
if err != nil {
13859+
return nil, err
13860+
}
13861+
}
13862+
13863+
filteredParameters := make([]database.WorkspaceBuildParameter, 0)
13864+
for _, buildID := range workspaceBuildIDs {
13865+
parameters, err := q.GetWorkspaceBuildParameters(ctx, buildID)
13866+
if err != nil {
13867+
return nil, err
13868+
}
13869+
filteredParameters = append(filteredParameters, parameters...)
13870+
}
13871+
13872+
return filteredParameters, nil
1385213873
}
1385313874

1385413875
func (q *FakeQuerier) GetAuthorizedUsers(ctx context.Context, arg database.GetUsersParams, prepared rbac.PreparedAuthorized) ([]database.GetUsersRow, error) {

0 commit comments

Comments
 (0)