Skip to content

Commit b0fe9bc

Browse files
kylecarbskylecarbs
authored
chore: Upgrade to Go 1.19 (#3617)
This is required as part of #3505.
1 parent d37fb05 commit b0fe9bc

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+144
-86
lines changed

‎.github/workflows/coder.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,11 @@ jobs:
9696
- uses: actions/checkout@v3
9797
- uses: actions/setup-go@v3
9898
with:
99-
go-version: "~1.18"
99+
go-version: "~1.19"
100100
- name: golangci-lint
101101
uses: golangci/golangci-lint-action@v3.2.0
102102
with:
103-
version: v1.46.0
103+
version: v1.48.0
104104

105105
check-enterprise-imports:
106106
name: check/enterprise-imports
@@ -199,7 +199,7 @@ jobs:
199199
version: "3.20.0"
200200
- uses: actions/setup-go@v3
201201
with:
202-
go-version: "~1.18"
202+
go-version: "~1.19"
203203

204204
- name: Echo Go Cache Paths
205205
id: go-cache-paths
@@ -283,7 +283,7 @@ jobs:
283283

284284
- uses: actions/setup-go@v3
285285
with:
286-
go-version: "~1.18"
286+
go-version: "~1.19"
287287

288288
- name: Echo Go Cache Paths
289289
id: go-cache-paths
@@ -370,7 +370,7 @@ jobs:
370370

371371
- uses: actions/setup-go@v3
372372
with:
373-
go-version: "~1.18"
373+
go-version: "~1.19"
374374

375375
- name: Echo Go Cache Paths
376376
id: go-cache-paths
@@ -453,7 +453,7 @@ jobs:
453453

454454
- uses: actions/setup-go@v3
455455
with:
456-
go-version: "~1.18"
456+
go-version: "~1.19"
457457

458458
- name: Echo Go Cache Paths
459459
id: go-cache-paths
@@ -558,7 +558,7 @@ jobs:
558558
# Go is required for uploading the test results to datadog
559559
- uses: actions/setup-go@v3
560560
with:
561-
go-version: "~1.18"
561+
go-version: "~1.19"
562562

563563
- uses: actions/setup-node@v3
564564
with:
@@ -616,7 +616,7 @@ jobs:
616616
# Go is required for uploading the test results to datadog
617617
- uses: actions/setup-go@v3
618618
with:
619-
go-version: "~1.18"
619+
go-version: "~1.19"
620620

621621
- uses: hashicorp/setup-terraform@v2
622622
with:

‎.vscode/settings.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"cSpell.words": [
33
"apps",
44
"awsidentity",
5+
"bodyclose",
56
"buildinfo",
67
"buildname",
78
"circbuf",
@@ -52,6 +53,7 @@
5253
"ntqry",
5354
"OIDC",
5455
"oneof",
56+
"paralleltest",
5557
"parameterscopeid",
5658
"pqtype",
5759
"prometheusmetrics",
@@ -80,6 +82,7 @@
8082
"tfjson",
8183
"tfplan",
8284
"tfstate",
85+
"tparallel",
8386
"trimprefix",
8487
"turnconn",
8588
"typegen",

‎agent/reaper/reaper_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ func TestReap(t *testing.T) {
2929
// exited processes and passing the PIDs through the shared
3030
// channel.
3131
t.Run("OK", func(t *testing.T) {
32+
t.Parallel()
3233
pids := make(reap.PidCh, 1)
3334
err := reaper.ForkReap(
3435
reaper.WithPIDCallback(pids),

‎cli/cliflag/cliflag.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
//
77
// Will produce the following usage docs:
88
//
9-
// -a, --address string The address to serve the API and dashboard (uses $CODER_ADDRESS). (default "127.0.0.1:3000")
10-
//
9+
// -a, --address string The address to serve the API and dashboard (uses $CODER_ADDRESS). (default "127.0.0.1:3000")
1110
package cliflag
1211

1312
import (

‎cli/cliflag/cliflag_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import (
1414
)
1515

1616
// Testcliflag cannot run in parallel because it uses t.Setenv.
17+
//
1718
//nolint:paralleltest
1819
func TestCliflag(t *testing.T) {
1920
t.Run("StringDefault", func(t *testing.T) {

‎cli/configssh.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ func currentBinPath(w io.Writer) (string, error) {
558558

559559
// diffBytes takes two byte slices and diffs them as if they were in a
560560
// file named name.
561-
//nolint: revive // Color is an option, not a control coupling.
561+
// nolint: revive // Color is an option, not a control coupling.
562562
func diffBytes(name string, b1, b2 []byte, color bool) ([]byte, error) {
563563
var buf bytes.Buffer
564564
var opts []write.Option

‎cli/delete_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import (
1515
)
1616

1717
func TestDelete(t *testing.T) {
18+
t.Parallel()
1819
t.Run("WithParameter", func(t *testing.T) {
1920
t.Parallel()
2021
client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerD: true})

‎cli/gitssh_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import (
2222
func TestGitSSH(t *testing.T) {
2323
t.Parallel()
2424
t.Run("Dial", func(t *testing.T) {
25+
t.Parallel()
2526
client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerD: true})
2627
user := coderdtest.CreateFirstUser(t, client)
2728

‎cli/publickey_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import (
1313
func TestPublicKey(t *testing.T) {
1414
t.Parallel()
1515
t.Run("OK", func(t *testing.T) {
16+
t.Parallel()
1617
client := coderdtest.New(t, nil)
1718
_ = coderdtest.CreateFirstUser(t, client)
1819
cmd, root := clitest.New(t, "publickey")

‎cli/root_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import (
1515
)
1616

1717
func TestRoot(t *testing.T) {
18+
t.Parallel()
1819
t.Run("FormatCobraError", func(t *testing.T) {
1920
t.Parallel()
2021

0 commit comments

Comments
 (0)