change rotate key logs to debug

hugodutka · hugodutka · commit b1b217b3e556 · 2025-02-18T18:02:08.000Z
diff --git a/cli/server_test.go b/cli/server_test.go
@@ -273,18 +273,23 @@ func TestServer(t *testing.T) {
 		}
 
 		countLines := func(fullOutput string, terminalWidth int) int {
-			lines := strings.Split(fullOutput, "\n")
-			count := 0
+			linesByNewline := strings.Split(fullOutput, "\n")
+			countByWidth := 0
 		lineLoop:
-			for _, line := range lines {
+			for _, line := range linesByNewline {
 				for _, ignoreLine := range ignoreLines {
 					if strings.Contains(line, ignoreLine) {
 						continue lineLoop
 					}
 				}
-				count += (len(line) + terminalWidth - 1) / terminalWidth
+				if line == "" {
+					// Empty lines take up one line.
+					countByWidth++
+				} else {
+					countByWidth += (len(line) + terminalWidth - 1) / terminalWidth
+				}
 			}
-			return count
+			return countByWidth
 		}
 
 		terminalWidth := 80
diff --git a/coderd/cryptokeys/rotate.go b/coderd/cryptokeys/rotate.go
@@ -152,7 +152,7 @@ func (k *rotator) rotateKeys(ctx context.Context) error {
 					}
 				}
 				if validKeys == 0 {
-					k.logger.Info(ctx, "no valid keys detected, inserting new key",
+					k.logger.Debug(ctx, "no valid keys detected, inserting new key",
 						slog.F("feature", feature),
 					)
 					_, err := k.insertNewKey(ctx, tx, feature, now)
@@ -194,7 +194,7 @@ func (k *rotator) insertNewKey(ctx context.Context, tx database.Store, feature d
 		return database.CryptoKey{}, xerrors.Errorf("inserting new key: %w", err)
 	}
 
-	k.logger.Info(ctx, "inserted new key for feature", slog.F("feature", feature))
+	k.logger.Debug(ctx, "inserted new key for feature", slog.F("feature", feature))
 	return newKey, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -273,18 +273,23 @@ func TestServer(t *testing.T) {`
`273`	`273`	`}`
`274`	`274`
`275`	`275`	`countLines := func(fullOutput string, terminalWidth int) int {`
`276`		`- lines := strings.Split(fullOutput, "\n")`
`277`		`- count := 0`
	`276`	`+ linesByNewline := strings.Split(fullOutput, "\n")`
	`277`	`+ countByWidth := 0`
`278`	`278`	`lineLoop:`
`279`		`- for _, line := range lines {`
	`279`	`+ for _, line := range linesByNewline {`
`280`	`280`	`for _, ignoreLine := range ignoreLines {`
`281`	`281`	`if strings.Contains(line, ignoreLine) {`
`282`	`282`	`continue lineLoop`
`283`	`283`	`}`
`284`	`284`	`}`
`285`		`- count += (len(line) + terminalWidth - 1) / terminalWidth`
	`285`	`+ if line == "" {`
	`286`	`+ // Empty lines take up one line.`
	`287`	`+ countByWidth++`
	`288`	`+ } else {`
	`289`	`+ countByWidth += (len(line) + terminalWidth - 1) / terminalWidth`
	`290`	`+ }`
`286`	`291`	`}`
`287`		`- return count`
	`292`	`+ return countByWidth`
`288`	`293`	`}`
`289`	`294`
`290`	`295`	`terminalWidth := 80`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ func (k *rotator) rotateKeys(ctx context.Context) error {`
`152`	`152`	`}`
`153`	`153`	`}`
`154`	`154`	`if validKeys == 0 {`
`155`		`- k.logger.Info(ctx, "no valid keys detected, inserting new key",`
	`155`	`+ k.logger.Debug(ctx, "no valid keys detected, inserting new key",`
`156`	`156`	`slog.F("feature", feature),`
`157`	`157`	`)`
`158`	`158`	`_, err := k.insertNewKey(ctx, tx, feature, now)`
`@@ -194,7 +194,7 @@ func (k *rotator) insertNewKey(ctx context.Context, tx database.Store, feature d`
`194`	`194`	`return database.CryptoKey{}, xerrors.Errorf("inserting new key: %w", err)`
`195`	`195`	`}`
`196`	`196`
`197`		`- k.logger.Info(ctx, "inserted new key for feature", slog.F("feature", feature))`
	`197`	`+ k.logger.Debug(ctx, "inserted new key for feature", slog.F("feature", feature))`
`198`	`198`	`return newKey, nil`
`199`	`199`	`}`
`200`	`200`