Read params from file for template/workspace creation

AbhineetJain · AbhineetJain · commit b35b7b357c35 · 2022-05-19T04:57:58.000Z
diff --git a/cli/create.go b/cli/create.go
@@ -2,11 +2,13 @@ package cli
 
 import (
 	"fmt"
+	"io/ioutil"
 	"time"
 
 	"github.com/spf13/cobra"
 	"golang.org/x/exp/slices"
 	"golang.org/x/xerrors"
+	"gopkg.in/yaml.v3"
 
 	"github.com/coder/coder/cli/cliflag"
 	"github.com/coder/coder/cli/cliui"
@@ -18,6 +20,7 @@ func create() *cobra.Command {
 	var (
 		workspaceName string
 		templateName  string
+		parameterFile string
 	)
 	cmd := &cobra.Command{
 		Annotations: workspaceCommand,
@@ -117,23 +120,49 @@ func create() *cobra.Command {
 				return err
 			}
 
-			printed := false
+			parameterValues := make(map[string]string)
+
+			if parameterFile != "" {
+				parameterFileContents, err := ioutil.ReadFile(parameterFile)
+
+				if err != nil {
+					return err
+				}
+
+				err = yaml.Unmarshal(parameterFileContents, &parameterValues)
+
+				if err != nil {
+					return err
+				}
+			}
+
+			disclaimerPrinted := false
 			parameters := make([]codersdk.CreateParameterRequest, 0)
 			for _, parameterSchema := range parameterSchemas {
 				if !parameterSchema.AllowOverrideSource {
 					continue
 				}
-				if !printed {
+				if !disclaimerPrinted {
 					_, _ = fmt.Fprintln(cmd.OutOrStdout(), cliui.Styles.Paragraph.Render("This template has customizable parameters. Values can be changed after create, but may have unintended side effects (like data loss).")+"\r\n")
-					printed = true
+					disclaimerPrinted = true
 				}
-				value, err := cliui.ParameterSchema(cmd, parameterSchema)
+
+				var parameterValue string
+				if parameterFile != "" {
+					if parameterValues[parameterSchema.Name] == "" {
+						return xerrors.Errorf("Parameter value absent in parameter file for %q!", parameterSchema.Name)
+					}
+					parameterValue = parameterValues[parameterSchema.Name]
+				} else {
+					parameterValue, err = cliui.ParameterSchema(cmd, parameterSchema)
+				}
+
 				if err != nil {
 					return err
 				}
 				parameters = append(parameters, codersdk.CreateParameterRequest{
 					Name:              parameterSchema.Name,
-					SourceValue:       value,
+					SourceValue:       parameterValue,
 					SourceScheme:      database.ParameterSourceSchemeData,
 					DestinationScheme: parameterSchema.DefaultDestinationScheme,
 				})
@@ -195,5 +224,6 @@ func create() *cobra.Command {
 	}
 
 	cliflag.StringVarP(cmd.Flags(), &templateName, "template", "t", "CODER_TEMPLATE_NAME", "", "Specify a template name.")
+	cliflag.StringVarP(cmd.Flags(), &parameterFile, "parameter-file", "", "CODER_PARAMETER_FILE", "", "Specify a file path with parameter values.")
 	return cmd
 }
diff --git a/cli/templatecreate.go b/cli/templatecreate.go
@@ -2,6 +2,7 @@ package cli
 
 import (
 	"fmt"
+	"io/ioutil"
 	"os"
 	"path/filepath"
 	"sort"
@@ -11,6 +12,7 @@ import (
 	"github.com/briandowns/spinner"
 	"github.com/spf13/cobra"
 	"golang.org/x/xerrors"
+	"gopkg.in/yaml.v3"
 
 	"github.com/coder/coder/cli/cliui"
 	"github.com/coder/coder/coderd/database"
@@ -21,9 +23,10 @@ import (
 
 func templateCreate() *cobra.Command {
 	var (
-		yes         bool
-		directory   string
-		provisioner string
+		yes           bool
+		directory     string
+		provisioner   string
+		parameterFile string
 	)
 	cmd := &cobra.Command{
 		Use:   "create [name]",
@@ -79,7 +82,7 @@ func templateCreate() *cobra.Command {
 			}
 			spin.Stop()
 
-			job, parameters, err := createValidTemplateVersion(cmd, client, organization, database.ProvisionerType(provisioner), resp.Hash)
+			job, parameters, err := createValidTemplateVersion(cmd, client, organization, database.ProvisionerType(provisioner), resp.Hash, parameterFile)
 			if err != nil {
 				return err
 			}
@@ -116,6 +119,7 @@ func templateCreate() *cobra.Command {
 	currentDirectory, _ := os.Getwd()
 	cmd.Flags().StringVarP(&directory, "directory", "d", currentDirectory, "Specify the directory to create from")
 	cmd.Flags().StringVarP(&provisioner, "test.provisioner", "", "terraform", "Customize the provisioner backend")
+	cmd.Flags().StringVarP(&parameterFile, "parameter-file", "", "", "Specify a file path with parameter values.")
 	// This is for testing!
 	err := cmd.Flags().MarkHidden("test.provisioner")
 	if err != nil {
@@ -125,7 +129,7 @@ func templateCreate() *cobra.Command {
 	return cmd
 }
 
-func createValidTemplateVersion(cmd *cobra.Command, client *codersdk.Client, organization codersdk.Organization, provisioner database.ProvisionerType, hash string, parameters ...codersdk.CreateParameterRequest) (*codersdk.TemplateVersion, []codersdk.CreateParameterRequest, error) {
+func createValidTemplateVersion(cmd *cobra.Command, client *codersdk.Client, organization codersdk.Organization, provisioner database.ProvisionerType, hash string, parameterFile string, parameters ...codersdk.CreateParameterRequest) (*codersdk.TemplateVersion, []codersdk.CreateParameterRequest, error) {
 	before := time.Now()
 	version, err := client.CreateTemplateVersion(cmd.Context(), organization.ID, codersdk.CreateTemplateVersionRequest{
 		StorageMethod:   database.ProvisionerStorageMethodFile,
@@ -184,20 +188,44 @@ func createValidTemplateVersion(cmd *cobra.Command, client *codersdk.Client, org
 			missingSchemas = append(missingSchemas, parameterSchema)
 		}
 		_, _ = fmt.Fprintln(cmd.OutOrStdout(), cliui.Styles.Paragraph.Render("This template has required variables! They are scoped to the template, and not viewable after being set.")+"\r\n")
+
+		parameterValuesFromFile := make(map[string]string)
+		if parameterFile != "" {
+			_, _ = fmt.Fprintln(cmd.OutOrStdout(), cliui.Styles.Paragraph.Render("Attempting to read the variables from the parameter file.")+"\r\n")
+			parameterFileContents, err := ioutil.ReadFile(parameterFile)
+
+			if err != nil {
+				return nil, nil, err
+			}
+
+			err = yaml.Unmarshal(parameterFileContents, &parameterValuesFromFile)
+
+			if err != nil {
+				return nil, nil, err
+			}
+		}
 		for _, parameterSchema := range missingSchemas {
-			value, err := cliui.ParameterSchema(cmd, parameterSchema)
+			var parameterValue string
+			if parameterFile != "" {
+				if parameterValuesFromFile[parameterSchema.Name] == "" {
+					return nil, nil, xerrors.Errorf("Required parameter value absent in parameter file for %q!", parameterSchema.Name)
+				}
+				parameterValue = parameterValuesFromFile[parameterSchema.Name]
+			} else {
+				parameterValue, err = cliui.ParameterSchema(cmd, parameterSchema)
+			}
 			if err != nil {
 				return nil, nil, err
 			}
 			parameters = append(parameters, codersdk.CreateParameterRequest{
 				Name:              parameterSchema.Name,
-				SourceValue:       value,
+				SourceValue:       parameterValue,
 				SourceScheme:      database.ParameterSourceSchemeData,
 				DestinationScheme: parameterSchema.DefaultDestinationScheme,
 			})
 			_, _ = fmt.Fprintln(cmd.OutOrStdout())
 		}
-		return createValidTemplateVersion(cmd, client, organization, provisioner, hash, parameters...)
+		return createValidTemplateVersion(cmd, client, organization, provisioner, hash, parameterFile, parameters...)
 	}
 
 	if version.Job.Status != codersdk.ProvisionerJobSucceeded {
