Check for license permission

code-asher · code-asher · commit b8bffa5143cf · 2024-07-31T17:32:39.000-08:00
An auditor for example appears to have the view deployment values
permission but cannot view licenses.
diff --git a/site/src/contexts/auth/permissions.tsx b/site/src/contexts/auth/permissions.tsx
@@ -14,6 +14,7 @@ export const checks = {
   createOrganization: "createOrganization",
   editAnyOrganization: "editAnyOrganization",
   viewAnyGroup: "viewAnyGroup",
+  viewAllLicenses: "viewAllLicenses",
 } as const;
 
 export const permissionsToCheck = {
@@ -111,6 +112,12 @@ export const permissionsToCheck = {
     },
     action: "read",
   },
+  [checks.viewAllLicenses]: {
+    object: {
+      resource_type: "license",
+    },
+    action: "read",
+  },
 } as const;
 
 export type Permissions = Record<keyof typeof permissionsToCheck, boolean>;
diff --git a/site/src/pages/ManagementSettingsPage/SidebarView.stories.tsx b/site/src/pages/ManagementSettingsPage/SidebarView.stories.tsx
@@ -49,6 +49,15 @@ export const NoAuditLog: Story = {
   },
 };
 
+export const NoLicenses: Story = {
+  args: {
+    permissions: {
+      ...MockPermissions,
+      viewAllLicenses: false,
+    },
+  },
+};
+
 export const NoDeploymentValues: Story = {
   args: {
     permissions: {
diff --git a/site/src/pages/ManagementSettingsPage/SidebarView.tsx b/site/src/pages/ManagementSettingsPage/SidebarView.tsx
@@ -112,7 +112,7 @@ const DeploymentSettingsNavigation: FC<DeploymentSettingsNavigationProps> = (
           {props.permissions.viewDeploymentValues && (
             <SidebarNavSubItem href="general">General</SidebarNavSubItem>
           )}
-          {props.permissions.viewDeploymentValues && (
+          {props.permissions.viewAllLicenses && (
             <SidebarNavSubItem href="licenses">Licenses</SidebarNavSubItem>
           )}
           {props.permissions.editDeploymentValues && (
diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts
@@ -2498,6 +2498,7 @@ export const MockPermissions: Permissions = {
   createOrganization: true,
   editAnyOrganization: true,
   viewAnyGroup: true,
+  viewAllLicenses: true,
 };
 
 export const MockDeploymentConfig: DeploymentConfig = {
