Skip to content

Commit c2417be

Browse files
committed
fix: Remove action from build cancelation names
This looked weird in the UI and didn't conform to our other states.
1 parent 56b963a commit c2417be

File tree

3 files changed

+4
-17
lines changed

3 files changed

+4
-17
lines changed

codersdk/workspacedisplaystatus.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ func WorkspaceDisplayStatus(jobStatus ProvisionerJobStatus, transition Workspace
3737
case ProvisionerJobPending:
3838
return "Queued"
3939
case ProvisionerJobCanceling:
40-
return "Canceling action"
40+
return "Canceling"
4141
case ProvisionerJobCanceled:
42-
return "Canceled action"
42+
return "Canceled"
4343
case ProvisionerJobFailed:
4444
return "Failed"
4545
default:

codersdk/workspacedisplaystatus_internal_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,13 @@ func TestWorkspaceDisplayStatus(t *testing.T) {
5656
name: "CancelingStatusWithStartTransition",
5757
jobStatus: ProvisionerJobCanceling,
5858
transition: WorkspaceTransitionStart,
59-
want: "Canceling action",
59+
want: "Canceling",
6060
},
6161
{
6262
name: "CanceledStatusWithStartTransition",
6363
jobStatus: ProvisionerJobCanceled,
6464
transition: WorkspaceTransitionStart,
65-
want: "Canceled action",
65+
want: "Canceled",
6666
},
6767
{
6868
name: "FailedStatusWithDeleteTransition",

site/src/i18n/en/common.json

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,4 @@
11
{
2-
"workspaceStatus": {
3-
"loading": "Loading",
4-
"running": "Running",
5-
"starting": "Starting",
6-
"stopping": "Stopping",
7-
"stopped": "Stopped",
8-
"deleting": "Deleting",
9-
"deleted": "Deleted",
10-
"canceling": "Canceling action",
11-
"canceled": "Canceled action",
12-
"failed": "Failed",
13-
"pending": "Pending"
14-
},
152
"deleteDialog": {
163
"title": "Delete {{entity}}",
174
"intro": "Deleting this {{entity}} is irreversible!",

0 commit comments

Comments
 (0)