Target text in e2e

presleyp · presleyp · commit c5619f8903fa · 2022-03-30T00:26:13.000Z
diff --git a/site/e2e/pom/SignInPage.ts b/site/e2e/pom/SignInPage.ts
@@ -7,8 +7,8 @@ export class SignInPage extends BasePom {
   }
 
   async submitBuiltInAuthentication(email: string, password: string): Promise<void> {
-    await this.page.fill("id=signin-form-inpt-email", email)
-    await this.page.fill("id=signin-form-inpt-password", password)
-    await this.page.click("id=signin-form-submit")
+    await this.page.fill("text=Email", email)
+    await this.page.fill("text=Password", password)
+    await this.page.click("text=Sign In")
   }
 }
diff --git a/site/src/components/SignIn/SignInForm.tsx b/site/src/components/SignIn/SignInForm.tsx
@@ -89,11 +89,7 @@ export const SignInForm: React.FC<SignInFormProps> = ({ isLoading, authErrorMess
           type="password"
           variant="outlined"
         />
-        {authErrorMessage && (
-          <FormHelperText data-testid="sign-in-error" error>
-            {Language.authErrorMessage}
-          </FormHelperText>
-        )}
+        {authErrorMessage && <FormHelperText error>{Language.authErrorMessage}</FormHelperText>}
         <div className={styles.submitBtn}>
           <LoadingButton color="primary" loading={isLoading} fullWidth type="submit" variant="contained">
             {isLoading ? "" : Language.signIn}

Original file line number	Diff line number	Diff line change
`@@ -7,8 +7,8 @@ export class SignInPage extends BasePom {`
`7`	`7`	`}`
`8`	`8`
`9`	`9`	`async submitBuiltInAuthentication(email: string, password: string): Promise<void> {`
`10`		`- await this.page.fill("id=signin-form-inpt-email", email)`
`11`		`- await this.page.fill("id=signin-form-inpt-password", password)`
`12`		`- await this.page.click("id=signin-form-submit")`
	`10`	`+ await this.page.fill("text=Email", email)`
	`11`	`+ await this.page.fill("text=Password", password)`
	`12`	`+ await this.page.click("text=Sign In")`
`13`	`13`	`}`
`14`	`14`	`}`