fix: duplicate tags map in mutation to resolve race

kylecarbs · kylecarbs · commit c6824ca145db · 2024-07-29T18:29:02.000Z
See: https://github.com/coder/coder/actions/runs/10149619748/job/28064952716?pr=14046
diff --git a/provisionersdk/provisionertags.go b/provisionersdk/provisionertags.go
@@ -18,9 +18,10 @@ const (
 // NOTE: "owner" must NEVER be nil. Otherwise it will end up being
 // duplicated in the database, as idx_provisioner_daemons_name_owner_key
 // is a partial unique index that includes a JSON field.
-func MutateTags(userID uuid.UUID, tags map[string]string) map[string]string {
-	if tags == nil {
-		tags = map[string]string{}
+func MutateTags(userID uuid.UUID, provided map[string]string) map[string]string {
+	tags := map[string]string{}
+	for k, v := range provided {
+		tags[k] = v
 	}
 	_, ok := tags[TagScope]
 	if !ok {
