chore: updates for PR review

jaaydenh · jaaydenh · commit c784d7081270 · 2024-07-16T14:56:05.000Z
diff --git a/codersdk/organizations.go b/codersdk/organizations.go
@@ -366,7 +366,7 @@ func (c *Client) TemplatesByOrganization(ctx context.Context, organizationID uui
 type TemplateFilter struct {
 	OrganizationID uuid.UUID `json:"organization_id,omitempty" format:"uuid" typescript:"-"`
 	FilterQuery    string    `json:"q,omitempty"`
-	ExactName      string
+	ExactName      string    `json:"exact_name,omitempty"`
 }
 
 // asRequestOption returns a function that can be used in (*Client).Request.
diff --git a/site/src/api/queries/templates.ts b/site/src/api/queries/templates.ts
@@ -47,9 +47,7 @@ export const templatesByOrganizationId = (
   };
 };
 
-export const templates = (filter: TemplateFilter = {
-  ExactName: ""
-}) => {
+export const templates = (filter?: TemplateFilter) => {
   return {
     queryKey: ["templates", filter],
     queryFn: () => API.getTemplates(filter),
diff --git a/site/src/api/typesGenerated.ts b/site/src/api/typesGenerated.ts
diff --git a/site/src/utils/templateAggregators.ts b/site/src/utils/templateAggregators.ts
@@ -10,16 +10,16 @@ export const getTemplatesByTag = (
     all: templates,
   };
 
-  templates.forEach((template) => {
-    template.tags.forEach((tag) => {
+  for (const template of templates) {
+    for (const tag of template.tags) {
       // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- this can be undefined
       if (tags[tag]) {
         tags[tag].push(template);
       } else {
         tags[tag] = [template];
       }
-    });
-  });
+    };
+  };
 
   return tags;
 };
@@ -29,14 +29,14 @@ export const getTemplatesByOrg = (templates: Template[]): TemplatesByOrg => {
     all: templates,
   };
 
-  templates.forEach((template) => {
+  for (const template of templates) {
     const org = template.organization_name;
     if (orgs[org]) {
       orgs[org].push(template);
     } else {
       orgs[org] = [template];
     }
-  });
+  };
 
   return orgs;
 };

Original file line number	Diff line number	Diff line change
`@@ -366,7 +366,7 @@ func (c *Client) TemplatesByOrganization(ctx context.Context, organizationID uui`
`366`	`366`	`type TemplateFilter struct {`
`367`	`367`	OrganizationID uuid.UUID `json:"organization_id,omitempty" format:"uuid" typescript:"-"`
`368`	`368`	FilterQuery string `json:"q,omitempty"`
`369`		`- ExactName string`
	`369`	+ ExactName string `json:"exact_name,omitempty"`
`370`	`370`	`}`
`371`	`371`
`372`	`372`	`// asRequestOption returns a function that can be used in (*Client).Request.`