Minor improvements

BrunoQuaresma · BrunoQuaresma · commit c986e51d997b · 2024-08-07T13:30:58.000Z
diff --git a/site/src/pages/DeploySettingsPage/NotificationsPage/NotificationsPage.tsx b/site/src/pages/DeploySettingsPage/NotificationsPage/NotificationsPage.tsx
@@ -119,7 +119,19 @@ export const NotificationsPage: FC = () => {
           <>
             Control delivery methods for notifications on this deployment.
             Notifications may be disabled in your{" "}
-            <Link to="/settings/notifications">profile settings</Link>.
+            <Link
+              to="/settings/notifications"
+              css={(theme) => ({
+                color: theme.roles.active.fill.outline,
+                textDecoration: "none",
+                "&: hover": {
+                  textDecoration: "underline",
+                },
+              })}
+            >
+              profile settings
+            </Link>
+            .
           </>
         }
         layout="fluid"
@@ -178,7 +190,9 @@ const EventsView: FC<EventsViewProps> = ({
   templatesByGroup,
 }) => {
   const isUsingWebhook = availableMethods.includes("webhook");
+  const isUsingSmpt = availableMethods.includes("smtp");
   const webhookEndpoint = notificationsConfig?.webhook.endpoint;
+  const smtpConfig = notificationsConfig?.email;
 
   return (
     <Stack spacing={3}>
@@ -187,6 +201,13 @@ const EventsView: FC<EventsViewProps> = ({
           Webhook method is enabled, but the endpoint is not configured.
         </Alert>
       )}
+
+      {isUsingSmpt && !smtpConfig && (
+        <Alert severity="warning">
+          SMTP method is enabled, but is not configured.
+        </Alert>
+      )}
+
       {Object.entries(templatesByGroup).map(([group, templates]) => (
         <Card
           key={group}
diff --git a/site/src/testHelpers/storybook.tsx b/site/src/testHelpers/storybook.tsx
@@ -97,7 +97,7 @@ export const withDesktopViewport = (Story: FC) => (
 
 export const withAuthProvider = (Story: FC, { parameters }: StoryContext) => {
   if (!parameters.user) {
-    console.warn("You forgot to add `parameters.user` to your story");
+    throw new Error("You forgot to add `parameters.user` to your story");
   }
   // eslint-disable-next-line react-hooks/rules-of-hooks -- decorators are components
   const queryClient = useQueryClient();

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ export const withDesktopViewport = (Story: FC) => (`
`97`	`97`
`98`	`98`	`export const withAuthProvider = (Story: FC, { parameters }: StoryContext) => {`
`99`	`99`	`if (!parameters.user) {`
`100`		- console.warn("You forgot to add `parameters.user` to your story");
	`100`	+ throw new Error("You forgot to add `parameters.user` to your story");
`101`	`101`	`}`
`102`	`102`	`// eslint-disable-next-line react-hooks/rules-of-hooks -- decorators are components`
`103`	`103`	`const queryClient = useQueryClient();`