Skip to content

Commit cee93cb

Browse files
committed
Review comments
Signed-off-by: Danny Kopping <danny@coder.com>
1 parent e868752 commit cee93cb

File tree

5 files changed

+6
-4
lines changed

5 files changed

+6
-4
lines changed

coderd/database/dump.sql

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
ALTER TABLE notification_messages
2-
ADD COLUMN queued_seconds FLOAT NULL;
2+
ADD COLUMN queued_seconds INTEGER NULL;

coderd/database/models.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

coderd/notifications/metrics.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func NewMetrics(reg prometheus.Registerer) *Metrics {
4848
// Aggregating on LabelTemplateID as well would cause a cardinality explosion.
4949
QueuedSeconds: promauto.With(reg).NewHistogramVec(prometheus.HistogramOpts{
5050
Name: "queued_seconds", Namespace: ns, Subsystem: subsystem,
51-
Buckets: []float64{0.1, 1, 5, 15, 30, 60, 120, 300, 600, 3600, 86400},
51+
Buckets: []float64{1, 5, 15, 30, 60, 120, 300, 600, 3600, 86400},
5252
Help: "The time elapsed between a notification being enqueued in the store and retrieved for processing " +
5353
"(measures the latency of the notifications system). This should generally be within CODER_NOTIFICATIONS_FETCH_INTERVAL " +
5454
"seconds; higher values for a sustained period indicates delayed processing and CODER_NOTIFICATIONS_LEASE_COUNT " +

coderd/notifications/metrics_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ func TestMetrics(t *testing.T) {
2828
t.Parallel()
2929

3030
// setup
31+
32+
// Requires postgres because retry business logic is required, and this is only implemented in the database.
3133
if !dbtestutil.WillUsePostgres() {
3234
t.Skip("This test requires postgres")
3335
}

0 commit comments

Comments
 (0)