fix: Revert bad change

mafredri · mafredri · commit d263af2d9246 · 2022-07-25T17:45:29.000+03:00
diff --git a/cli/portforward_test.go b/cli/portforward_test.go
@@ -394,7 +394,11 @@ func runAgent(t *testing.T, client *codersdk.Client, userID uuid.UUID) ([]coders
 	clitest.SetupConfig(t, client, root)
 	errC := make(chan error)
 	agentCtx, agentCancel := context.WithCancel(ctx)
-	defer agentCancel()
+	t.Cleanup(func() {
+		agentCancel()
+		err := <-errC
+		require.NoError(t, err)
+	})
 	go func() {
 		errC <- cmd.ExecuteContext(agentCtx)
 	}()
@@ -403,9 +407,6 @@ func runAgent(t *testing.T, client *codersdk.Client, userID uuid.UUID) ([]coders
 	resources, err := client.WorkspaceResourcesByBuild(context.Background(), workspace.LatestBuild.ID)
 	require.NoError(t, err)
 
-	err := <-errC
-	require.NoError(t, err)
-
 	return resources, workspace
 }
 
