fix(site): .eslintrc.yaml tsconfigRootDir

greyscaled · greyscaled · commit d9da0f31e0ae · 2022-03-13T21:20:16.000Z
Summary: The .eslintrc.yaml is located in site, rather than the root of the repository. The VS Code plugin has a CWD of the repository root, so it looks for tsconfig.test.json in the root rather in site. See Also: - typescript-eslint/typescript-eslint#251
diff --git a/site/.eslintrc.yaml b/site/.eslintrc.yaml
@@ -17,12 +17,16 @@ extends:
 parser: "@typescript-eslint/parser"
 parserOptions:
   ecmaVersion: 2018
-  project:
-    - "./tsconfig.test.json"
+  project: "./tsconfig.test.json"
   sourceType: module
   ecmaFeatures:
     jsx: true
-  tsconfigRootDir: "./"
+  # REMARK(Grey): tsconfigRootDir is not relative to .eslintrc.yaml in the VS
+  #               Code plugin (instead it's the root directory). Therefore we
+  #               need to tell it to consider ./site as the root.
+  # REMARK(Grey): We might want to move this to repository root eventually to
+  #               lint multiple projects (supply array to project property).
+  tsconfigRootDir: "./site"
 plugins:
   - "@typescript-eslint"
   - import
