Implement GetCryptoKeysByFeature method

sreya · sreya · commit dcf3b2765e9b · 2024-09-24T00:18:28.000Z
Add authorization check and call database method.
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
@@ -1406,7 +1406,10 @@ func (q *querier) GetCryptoKeys(ctx context.Context) ([]database.CryptoKey, erro
 }
 
 func (q *querier) GetCryptoKeysByFeature(ctx context.Context, feature database.CryptoKeyFeature) ([]database.CryptoKey, error) {
-	panic("not implemented")
+	if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceCryptoKey); err != nil {
+		return nil, err
+	}
+	return q.db.GetCryptoKeysByFeature(ctx, feature)
 }
 
 func (q *querier) GetDBCryptKeys(ctx context.Context) ([]database.DBCryptKey, error) {
diff --git a/coderd/keychain/dbkeychain_internal_test.go b/coderd/keychain/dbkeychain_internal_test.go
@@ -14,7 +14,7 @@ import (
 	"github.com/coder/quartz"
 )
 
-func Test_version(t *testing.T) {
+func Test_Version(t *testing.T) {
 	t.Parallel()
 
 	t.Run("HitsCache", func(t *testing.T) {
@@ -165,7 +165,7 @@ func Test_version(t *testing.T) {
 	})
 }
 
-func Test_latest(t *testing.T) {
+func Test_Latest(t *testing.T) {
 	t.Parallel()
 
 	t.Run("HitsCache", func(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -1406,7 +1406,10 @@ func (q *querier) GetCryptoKeys(ctx context.Context) ([]database.CryptoKey, erro`
`1406`	`1406`	`}`
`1407`	`1407`
`1408`	`1408`	`func (q *querier) GetCryptoKeysByFeature(ctx context.Context, feature database.CryptoKeyFeature) ([]database.CryptoKey, error) {`
`1409`		`- panic("not implemented")`
	`1409`	`+ if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceCryptoKey); err != nil {`
	`1410`	`+ return nil, err`
	`1411`	`+ }`
	`1412`	`+ return q.db.GetCryptoKeysByFeature(ctx, feature)`
`1410`	`1413`	`}`
`1411`	`1414`
`1412`	`1415`	`func (q *querier) GetDBCryptKeys(ctx context.Context) ([]database.DBCryptKey, error) {`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ import (`
`14`	`14`	`"github.com/coder/quartz"`
`15`	`15`	`)`
`16`	`16`
`17`		`-func Test_version(t *testing.T) {`
	`17`	`+func Test_Version(t *testing.T) {`
`18`	`18`	`t.Parallel()`
`19`	`19`
`20`	`20`	`t.Run("HitsCache", func(t *testing.T) {`
`@@ -165,7 +165,7 @@ func Test_version(t *testing.T) {`
`165`	`165`	`})`
`166`	`166`	`}`
`167`	`167`
`168`		`-func Test_latest(t *testing.T) {`
	`168`	`+func Test_Latest(t *testing.T) {`
`169`	`169`	`t.Parallel()`
`170`	`170`
`171`	`171`	`t.Run("HitsCache", func(t *testing.T) {`