Address PR feedback

mtojek · mtojek · commit efe4928e7090 · 2023-06-28T14:10:59.000+02:00
diff --git a/site/src/components/Workspace/Workspace.tsx b/site/src/components/Workspace/Workspace.tsx
@@ -218,9 +218,10 @@ export const Workspace: FC<React.PropsWithChildren<WorkspaceProps>> = ({
               <AlertTitle>Workspace build is pending</AlertTitle>
               <AlertDetail>
                 <div className={styles.alertPendingInQueue}>
-                  This build job is waiting for a provisioner to become
-                  available. If you have been waiting for an extended period,
-                  contact your administrator for assistance.
+                  This workspace build job is waiting for a provisioner to
+                  become available. If you have been waiting for an extended
+                  period of time, please contact your administrator for
+                  assistance.
                 </div>
                 <div>
                   Position in queue:{" "}
diff --git a/site/src/components/WorkspaceStatusBadge/WorkspaceStatusBadge.tsx b/site/src/components/WorkspaceStatusBadge/WorkspaceStatusBadge.tsx
@@ -43,8 +43,6 @@ export const WorkspaceStatusText: FC<
     workspace.latest_build.status,
   )
 
-  workspace.latest_build.job.queue_size
-
   return (
     <ChooseOne>
       {/* <ImpendingDeletionText/> determines its own visibility */}
diff --git a/site/src/utils/workspace.tsx b/site/src/utils/workspace.tsx
@@ -272,7 +272,7 @@ const getPendingWorkspaceStatusText = (
 ): string => {
   const { t } = i18next
 
-  if (provisionerJob === undefined || provisionerJob.queue_size === 0) {
+  if (!provisionerJob || provisionerJob.queue_size === 0) {
     return t("workspaceStatus.pending", { ns: "common" })
   }
   return "Position in queue: " + provisionerJob.queue_position

Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,6 @@ export const WorkspaceStatusText: FC<`
`43`	`43`	`workspace.latest_build.status,`
`44`	`44`	`)`
`45`	`45`
`46`		`- workspace.latest_build.job.queue_size`
`47`		`-`
`48`	`46`	`return (`
`49`	`47`	`<ChooseOne>`
`50`	`48`	`{/* <ImpendingDeletionText/> determines its own visibility */}`
Original file line number	Diff line number	Diff line change
`@@ -272,7 +272,7 @@ const getPendingWorkspaceStatusText = (`
`272`	`272`	`): string => {`
`273`	`273`	`const { t } = i18next`
`274`	`274`
`275`		`- if (provisionerJob === undefined \|\| provisionerJob.queue_size === 0) {`
	`275`	`+ if (!provisionerJob \|\| provisionerJob.queue_size === 0) {`
`276`	`276`	`return t("workspaceStatus.pending", { ns: "common" })`
`277`	`277`	`}`
`278`	`278`	`return "Position in queue: " + provisionerJob.queue_position`