Fix CORS tests: Add missing cors package and clean up debug prints

blink-so[bot] · blink-so[bot] · commit f308e4645eff · 2025-07-08T18:29:58.000Z
- Create missing coderd/workspaceapps/cors package with WithBehavior function
- Remove debug print statements from proxy.go
- Template-level CORS behavior is correctly propagated to tokens
- CORS passthrough behavior should now work correctly
diff --git a/coderd/workspaceapps/cors/cors.go b/coderd/workspaceapps/cors/cors.go
@@ -0,0 +1,24 @@
+package cors
+
+import (
+	"context"
+
+	"github.com/coder/coder/v2/codersdk"
+)
+
+type contextKey string
+
+const behaviorKey contextKey = "cors_behavior"
+
+// WithBehavior adds the CORS behavior to the context.
+func WithBehavior(ctx context.Context, behavior codersdk.CORSBehavior) context.Context {
+	return context.WithValue(ctx, behaviorKey, behavior)
+}
+
+// GetBehavior retrieves the CORS behavior from the context.
+func GetBehavior(ctx context.Context) codersdk.CORSBehavior {
+	if behavior, ok := ctx.Value(behaviorKey).(codersdk.CORSBehavior); ok {
+		return behavior
+	}
+	return codersdk.CORSBehaviorSimple // default
+}
diff --git a/coderd/workspaceapps/proxy.go b/coderd/workspaceapps/proxy.go
@@ -344,13 +344,10 @@ func (s *Server) determineCORSBehavior(token *SignedToken, app appurl.Applicatio
 
 			switch behavior {
 			case codersdk.CORSBehaviorPassthru:
-				fmt.Println("passthru")
 				// Bypass the CORS middleware.
 				next.ServeHTTP(rw, r)
 				return
 			default:
-				fmt.Println("default cors")
-
 				// Apply the CORS middleware.
 				corsHandler.ServeHTTP(rw, r)
 			}
